Andrew
Andrew
Note that the Go standard library still lacks an implementation for quantizer. So libraries like gogif are still very much necessary to manipulate GIF images. I tried several alternative libraries,...
Please don't enforce a PHONY declaration for tasks that are not declared in our Makefiles. That is, if `clean` isn't even implemented, then it should not be marked PHONY. Same...
I tried several variations of a configuration file like this, but none of them have any effect on the behavior of checkmake. checkmake.ini: ```ini [minphony] required=all clean ``` checkmake insists...
In order to more quickly distinguish between bmake and gmake files, we could create a new linter rule that warns on ambiguous files. Basically, `Makefile` is ambiguous. This can lead...
Can we please expand the number of precompiled ports of checkmake for the various Go friendly platform pairs? We could easily do ARM ports, FreeBSD ports, and more by asking...
Fixed the minphony implementation to actually support overriding from checkmake.ini file. Long term, there is some refactoring to do in the data models and overriding logic, such as for maxbodylength...
For large projects containing many makefiles, it would help the user out if checkmake automatically recursed over directories. Basically, use Go's builtin filepath Walk functionality, and ignore any non-directory files...
There are many ways to calculate the length of some text. Bytes, characters, runes, words, lines... I think the maxbodylength rule operates on lines, but the current warning string format...
checkmake has some odd behavior regarding phony targets. It specifies several minimum phony targets, such as `all`, `clean`, and `test`. But it doesn't actually validate whether the tasks are defined....
### Expected behaviour Blank makefile lines should be ignored before emitting warnings to logs. Also, a specific line *number* would be helpful for identifying any actual problematic makefile lines. ###...