Michael Abbott
Michael Abbott
From https://github.com/JuliaDiff/ChainRules.jl/pull/655: ```julia julia> test_rrule(getindex, Diagonal(rand(3)), 2, :) test_rrule: getindex on Diagonal{Float64, Vector{Float64}},Int64,Colon: Error During Test at /Users/me/.julia/packages/ChainRulesTestUtils/YbVdW/src/testers.jl:193 Got exception outside of a @test ArgumentError: cannot set off-diagonal entry (2,...
When tests fail, I think this package is somehow helpfully capturing the error (with `try`) and hiding it: ``` test_rrule: partialsort on Vector{Float64},UnitRange{Int64}: Error During Test at /home/runner/.julia/packages/ChainRulesTestUtils/YbVdW/src/testers.jl:193 [232](https://github.com/JuliaDiff/ChainRulesCore.jl/runs/8017765323?check_suite_focus=true#step:6:233) Got...
`test_rrule` checks that the rule accepts `thunks`. Should it also check that these aren't accidentally un-thunked more than once, by some passing in some `@thunk (COUNT[+=1]; val)` thing? That's a...
For testing https://github.com/JuliaDiff/ChainRules.jl/pull/644, it would be useful if we could have a variant of `TestConfig()` which only works in forward mode, and one which only works in reverse mode. This...
This seems to confuse the tester, it should not expect a tuple length 10 (the input) but shorter. https://github.com/JuliaDiff/ChainRules.jl/pull/570/files#diff-14d216cb53721d9360bbbcc399d93fff67f2594bd388162abbbe82c59ad1ba9fR229 ``` @test_skip test_frule(filter, >(0.5) ⊢ NoTangent(), xt10; check_inferred=false) check_result.jl:104 Expression: ActualPrimal...
Something is confused here, I'm pretty sure the rule gives the same result as the one for `permutedims`: ```julia julia> test_rrule(PermutedDimsArray, rand(3, 4, 5), (3, 1, 2); atol=0.1) test_rrule: PermutedDimsArray...
With https://github.com/JuliaDiff/ChainRules.jl/pull/565 I get these errors: ``` julia> test_frule(reshape, rand(4,4), 2, :) Test Summary: | Pass Total Time test_frule: reshape on Matrix{Float64},Int64,Colon | 4 4 0.4s Test.DefaultTestSet("test_frule: reshape on Matrix{Float64},Int64,Colon",...
```julia julia> ChainRulesTestUtils.test_approx(Tangent{Int}(; x=1), ZeroTangent()) ERROR: MethodError: test_approx(::Tangent{Int64, NamedTuple{(:x,), Tuple{Int64}}}, ::ZeroTangent) is ambiguous. Candidates: test_approx(x, ::AbstractZero) in ChainRulesTestUtils at /Users/me/.julia/packages/ChainRulesTestUtils/8dFTY/src/check_result.jl:34 test_approx(actual::Tangent{P, T}, expected) where {T, P} in ChainRulesTestUtils at /Users/me/.julia/packages/ChainRulesTestUtils/8dFTY/src/check_result.jl:108...
I don't have a MWE, but the original case ~~was here: https://github.com/JuliaDiff/ChainRules.jl/pull/570/files#diff-14d216cb53721d9360bbbcc399d93fff67f2594bd388162abbbe82c59ad1ba9fR236.~~ Maybe https://github.com/JuliaDiff/ChainRules.jl/pull/570/commits/944ccedc52b0fa41d48c04dab4dfa6f5a5565678#diff-14d216cb53721d9360bbbcc399d93fff67f2594bd388162abbbe82c59ad1ba9fR236 is the right link.
Even if this package's interval isn't the same as that in IntervalSets.jl, could it at least be an appropriate subtype? Ref https://github.com/mcabbott/AxisKeys.jl/issues/13, where that package could use this information to...