sonarqube-community-branch-plugin
sonarqube-community-branch-plugin copied to clipboard
mc1arke
SonarQube 10.5 compatibility
As far as I know this should be enough to produce a binary compatible plugin for SonarQube 10.5. See also https://github.com/mc1arke/sonarqube-community-branch-plugin/issues/900#issuecomment-2075860129.
This change isn't actually required: we only need the Sonarqube build dependency to allow us to compile the plugin. Given 10.5 hasn't changed any of the APIs we use then there's nothing that we need to change; I just need to push docker images and update the README
Are you sure? I'm by no means an expert in Java binary compatibility 😅. But at least the return type of ProjectAlmSettingDao#insertOrUpdate changed.
Are you sure? I'm by no means an expert in Java binary compatibility 😅. But at least the return type of
ProjectAlmSettingDao#insertOrUpdatechanged.
Sorry, I'd missed that change, and yes it will cause problems for anyone creating a new ALM setting. This means we'll need to create a release purely for 10.5 😞
would be nice to get this solved soon. We're currently having people that can't change some settings in their Projects due to this. Thanks a lot for your efforts 👍
Hello as usual for people in a hurry, SNAPSHOT version built from this PR can be downloaded using GitHub checks artefacts: https://github.com/mc1arke/sonarqube-community-branch-plugin/actions/runs/8969366962/artifacts/1476415257
Are you sure? I'm by no means an expert in Java binary compatibility 😅. But at least the return type of
ProjectAlmSettingDao#insertOrUpdatechanged.Sorry, I'd missed that change, and yes it will cause problems for anyone creating a new ALM setting. This means we'll need to create a release purely for 10.5 😞
You will probably need to build a new version for each new version of SQ, why not aligning the plugin version number with SQ version ? ;)
Since this PR still is open: By now SQ has released at least one newer build of 10.5: 10.5.1.90531
There shall not be any issue with new SQ 10.5 release. This plugin depends on API, and those are never modified for bugfixes releases. So at first sight no need update the SQ dependency version.
I hope @mc1arke is ok... Probably he just lost the enthusiasm to maintain this project.
I hope @mc1arke is ok... Probably he just lost the enthusiasm to maintain this project.
I'm ok, and haven't lost enthusiasm, just capacity to be able to perform testing of releases for now
Hello, fyi we decided to try the snapshot version of 1.19.1. As far as we can say from user experience, it seems to work without any new issues, and we are again capable of editing the sonar project configs 👍 thanks a lot.
Hi, we are also using the snapshot productively for about a month now. No issues so far.
@mc1arke seems that this PR contains the only small change necessary to make the plugin compatible with 10.5, feedbacks are positive, can you please merge and go for a 1.10 ?
I built the Docker image adrianmusante/sonarqube:10.5 which already has the plugin pre-configured, hopefully it will be of use to someone.
@mc1arke We have recently upgrade our SonarQube from 7.8 to 10.5 successfully. We are facing issue with branch analysis. We have installed community branch plugin for this with version 1.22.0, but this plugin after installation is not reflecting on web UI. I have done all the configurations mentioned here https://github.com/mc1arke/sonarqube-community-branch-plugin in manual installation.
Please help us resolve this issue
@Asmabagwan1 1.22.0 is only compatible with sonarqube 10.6. It's on the readme
https://github.com/mc1arke/sonarqube-community-branch-plugin?tab=readme-ov-file#compatibility
