Mark Byrne

Results 61 comments of Mark Byrne

> Update looks good. I realized why the iteration might be helpful, though. > > Without iterating, this PR no longer emits `invalid-slots` for this example: > > ```python >...

> We should probably fix the crash I can take a look. https://github.com/PyCQA/pylint/pull/6532

I could be wrong but regarding the "Refined name from outer scope" message. Isn't this correct of Pylint in highlighting what is also mentioned in the SO (pytest docs)? _If...

Hey @orSolocate that's OK with me. I wonder can we close this one because what @DanielNoord said is an idea I've seen before on other similar issues where Pylint can't...

Great report. I think it could be simply an issue with the type annotation, and not necessarily connected to TypedDict. ```python (venv310) Marks-MacBook-Air-2:programming markbyrne$ cat example.py from enum import Enum...

Perhaps the warning should suggest annotating the constant with typing.Final; that way Pylint would avoid checking something that mypy already can take care of.

> Isn't that an issue with python itself ? There's no real constant in python. even `typing.Final` do not prevent reassignment. The current solution to detect immutability seems optimal considering...

I agree with you @DanielNoord & @Pierre-Sassoulas; In my opinion this issue could be closed since the idea of constant for these variables is a convention in Python which doesn't...

We get the `invalid-name` message because the variable is _immutable_ _and_ it is not uppercase. This goes back to Pierre's point about [mutability](https://github.com/PyCQA/pylint/issues/7232#issuecomment-1196424116) - it is how Pylint determines what...

I meant immutable. Corrected my comment! So, it breaks for global string, for example, which is re-assigned.