pixel-perfect-firefox icon indicating copy to clipboard operation
pixel-perfect-firefox copied to clipboard

Add Overlay Button is gone

Open jnlissy opened this issue 12 years ago • 37 comments

The Add Overlay button gone. I can't upload an overlay. Firefox 14.0.1

jnlissy avatar Jul 17 '12 17:07 jnlissy

http://imageshack.us/photo/my-images/191/29678833.png/ I see it too.

daimonkor avatar Jul 17 '12 19:07 daimonkor

I'm also having the same issue Firefox 14.0.1 pp version 1.7.1

markstewart avatar Jul 17 '12 19:07 markstewart

Yes, me too. It started on Sunday 7/15. I'm not entirely sure, but I think there was an update to Firebug a few days ago, and I wonder if that's the problem.....

AlchemyCompSol avatar Jul 17 '12 22:07 AlchemyCompSol

I have the same problem. Win 7/32, Firefox 13.0.1. Upgrade to 14.0.1 didn't solve the problem.

eawer avatar Jul 18 '12 10:07 eawer

WIN 7 (With and Without admin permissions) FF 13.0.1

Have the same problem. Does JRE need to be installed?

kvigor avatar Jul 18 '12 17:07 kvigor

So do I, the button is gone at work (Win 7) and at home PC either (XP). What a pity ((

peter-gromov avatar Jul 18 '12 20:07 peter-gromov

solution!!

  1. open firebug
  2. click on the button - to open in a separate window
  3. close Firefox
  4. open Firefox
  5. open firebag
  6. "add overlay" button appear in the pixel perfect, but all the old layers will be lost and "add overlay" button will be lost when you expand firebug!!!!!

daimonkor avatar Jul 18 '12 20:07 daimonkor

@daimonkor that gives me the button back, however, I can't click within the input to turn on the overlay. Do you have this problem as well?

jnlissy avatar Jul 18 '12 20:07 jnlissy

what is that "I can't click within the input to turn on the overlay", please write more

my hack work for me and yes - I don`t add overlay after expand window firebug

http://prntscr.com/cb4ni http://prntscr.com/cb4v4

daimonkor avatar Jul 18 '12 20:07 daimonkor

I found this fix in user Enyby's comment on issue #46. Worked for me in OS X.

Search for the file PixelPerfectPanel.js within your profile.

in the PixelPerfectPanel.js file add line:

addMenuOption('Add Overlay', Firebug.PixelPerfectModule.addOverlay, false);

after:

addMenuOption('Hide Statusbar Icon', buildToggleBoolPrefFn(hideStatusBarPref), pixelPerfect.utils.getBoolPref(hideStatusBarPref));
addMenuOption('Hide Overlay When Inspecting', buildToggleBoolPrefFn(hideWhenFocusLostPref), pixelPerfect.utils.getBoolPref(hideWhenFocusLostPref));

Restart and the "Add Overlay" option should now appear in the drop down

markstewart avatar Jul 18 '12 20:07 markstewart

@daimonkor the input box left of the overlay, cannot be clicked. There is a little box you click within to turn on and off layers. So my button is back, but I can't turn on layers.

jnlissy avatar Jul 18 '12 21:07 jnlissy

yes, I see that and I reload page and overlay work

daimonkor avatar Jul 18 '12 21:07 daimonkor

where is PixelPerfectPanel.js on Windows XP?

daimonkor avatar Jul 18 '12 21:07 daimonkor

@daimonkor It should be inside your FF profile directory at this path:

extensions\[email protected]\chrome\pixelperfect\content\PixelPerfectPanel.js

To find your profile directory, in Firefox navigate to about:support and click on the button next to "Profile Folder".

markstewart avatar Jul 18 '12 21:07 markstewart

Yes, its work, but need restart firefox for work additional overlay

daimonkor avatar Jul 18 '12 22:07 daimonkor

I have teh same issue. Mac OS X Lion + Fx 14.0.1 + in Aurora as well. Any chance of getting this fixed soon?

Kolombiken avatar Jul 19 '12 08:07 Kolombiken

@markstewart . It doesnt work on Windows 7 for me .. Add overlay button is still not showing even after adding

addMenuOption('Add Overlay', Firebug.PixelPerfectModule.addOverlay, false);

to PixelPerfectPanel.js

thecodexpert avatar Jul 19 '12 10:07 thecodexpert

Hey guys good work you doing... well,

My System is Win 7 Home, FireFox 13.0.1 It was working for me until I tried to change the overlay with another one. I deleted the previous one and next, the Add Layer button had gone.!

I am having the same issue with no resolution at all. I searched for the PixelPerfectPanel.js but I couldn't find it in my system. Please tell where can I find it in my Win 7 Home. the only folders I see in extensions folder of FF look liike '{9e4e-dsdd-sdsdd....}'

Is there any update coming here soon?

mshoaibqureshi avatar Jul 20 '12 05:07 mshoaibqureshi

ok so I actually found the PixelPerfectPanel.js in the following path..

'C:\Users\myuser\AppData\Roaming\Mozilla\Firefox\Profiles\8648houh.default\extensions\[email protected]\chrome\pixelperfect\content'

I added the line

addMenuOption('Add Overlay', Firebug.PixelPerfectModule.addOverlay, false);

after

addMenuOption('Hide Statusbar Icon', buildToggleBoolPrefFn(hideStatusBarPref), pixelPerfect.utils.getBoolPref(hideStatusBarPref)); addMenuOption('Hide Overlay When Inspecting', buildToggleBoolPrefFn(hideWhenFocusLostPref), pixelPerfect.utils.getBoolPref(hideWhenFocusLostPref));

And it actually worked. I have now the add layer button in my dropdown, BUT, I still can't SHOW/HIDE the layer.

@daimonkor : please tell how to resolve that issue. mere restart didn't help

mshoaibqureshi avatar Jul 20 '12 06:07 mshoaibqureshi

http://prntscr.com/ce06c , but where is button?))

First work overlay failed sometimes, need restart firefox.

daimonkor avatar Jul 20 '12 07:07 daimonkor

@daimonkor: My issue is totally resolved! after adding that code, it just needed a few restarts.

BUT one more thing, I feel there still is some issue when it comes to tabbed overlays. I mean in FF, If I want to open different overlays in different tabs, I simply CAN'T Is there any feature coming like that??

mshoaibqureshi avatar Jul 20 '12 10:07 mshoaibqureshi

Yes I see it too (wtf?)((((( so need restart

daimonkor avatar Jul 20 '12 10:07 daimonkor

I've added the lines and refreshed a couple of times but it didn't work for me, no Add overlay in FF 14.0.1 on Lion.

zzarazza avatar Jul 23 '12 18:07 zzarazza

Could you guys give me path where I can find file PixelPerfectPanel.js in Lion?

ghost avatar Jul 23 '12 22:07 ghost

Oh, I figured it out now! For those who's needed or confused. Open Firefox. Type in address link "about:support". in Application Basics > Profile Folder click "Show in Finder" button. And find file there: extensions\[email protected]\chrome\pixelperfect\content\PixelPerfectPanel.js

in the PixelPerfectPanel.js file find this peace of code:

addMenuOption('Hide Statusbar Icon', buildToggleBoolPrefFn(hideStatusBarPref), pixelPerfect.utils.getBoolPref(hideStatusBarPref)); addMenuOption('Hide Overlay When Inspecting', buildToggleBoolPrefFn(hideWhenFocusLostPref), pixelPerfect.utils.getBoolPref(hideWhenFocusLostPref));

after above lines and before "return menuOptions;" add the following:

addMenuOption('Add Overlay', Firebug.PixelPerfectModule.addOverlay, false);

Save. Restart Firefox.

In the Pixel Perfect menu (click "arrow") you will find "Add overlay" option.

ghost avatar Jul 23 '12 22:07 ghost

Ukando: Thank you! That actually works. Can someone please do a real fix so we all don't need to hack the plugin?

Kolombiken avatar Jul 25 '12 11:07 Kolombiken

Please fix

charlesmeyer avatar Jul 25 '12 21:07 charlesmeyer

@markstewart : I have added the add overlay button. Thanks a lot!

monkviper avatar Jul 27 '12 03:07 monkviper

It is no button, it is context menu item((

daimonkor avatar Jul 27 '12 07:07 daimonkor

I'd like to see a fix for this - it's a great idea, but I'm not really inclined to jump through hoops to get it working...

yolise avatar Aug 02 '12 10:08 yolise