yaMBSiavr icon indicating copy to clipboard operation
yaMBSiavr copied to clipboard

Published 20 hours ago • verified publisher icon mbs38

Compatibility to tinyavr-1

Open chris-heo opened this issue 1 year ago • 3 comments

I added support and tested it with attiny816 and attiny1616.

Backwards-compatibility for "old" AVRs shouldn't be affected but wasn't tested (yet)

chris-heo avatar Dec 23 '23 19:12 chris-heo

Hi, thank you for your contribution.

In your commit you have mixed a vast change of formatting with a change of functionality. The formatting certainly leaves room for improvement but for comparing changes this is a nightmare.

Please split the functional and the formatting changes into two separate commits. After checking backwards compatibility I am happy to merge.

Best regards, Max

mbs38 avatar Dec 26 '23 18:12 mbs38

Here you go. Have to admit that I haven't tested the rework with actual HW.

chris-heo avatar Dec 27 '23 20:12 chris-heo

fixed 2 issues that slipped through and kept it from compiling. Sorry for that. Now tested on hardware with ATtiny1616.

chris-heo avatar Jan 09 '24 21:01 chris-heo