Matt Broadstone

Results 210 comments of Matt Broadstone

@carera the milestones are implemented as a stack, are you sure that your code is being run after the default implementation when doing this: ``` resource.create.write((req, res, ctx) => {...

@carera oops sorry I've been reading this incorrectly from the get-go (early morning here). This behavior is expected, and the best practice for overriding the default `write` milestone in this...

@carera yeah I understand, but the only way to change that at this point is to reverse the order in which milestones are evaluated which could be potentially disastrous for...

@carera basically the change boils down to changing this line: https://github.com/dchester/epilogue/blob/master/lib/Controllers/base.js#L207 from `this[name].push(callback);` to `this[name].unshift(callback);` Actually, that only breaks a single test in the test suite. I would strongly entertain...

@carera hence the major version bump. Users would have to opt-in to this new functionality, and would therefore know what was happening. I think the other potential benefit is that...

oops looks like I was wrong, they do in fact process the routes on a stack like we do.. back to the drawing board

@carera Okay yeah I see what you're saying. I dig your idea from above (with potentially slight modification) for more "low level" overriding of milestones: we would modify the existing...

@carera to be quite honest with you I didn't design it, I just took over maintenance of this module a few months after it was put out while I was...

Well of course it does, you're allowing them to override the target completely. At a certain point you need to trust the user, or rather that you've given them the...

@omayhemo with milestones you can essentially do whatever you want, can you be more specific?