FsPickler icon indicating copy to clipboard operation
FsPickler copied to clipboard

Extend FsPickler static methods to accept IPicklerResolver parameter.

Open mchylek opened this issue 2 years ago • 3 comments

This PR tries to resolve issue I found as part of extending Vagabond to use custom IPicklerResolver. I've noticed it works fine with Serialization but Vagabond.ComputeObjectDependencies use FsPickler.VisitObject that's currently missing support for providing custom resolver.

This change is not binary compatible as it's add optional parameter but I'm happy to update it as new methods overloads if needed.

It's partially related to #123

mchylek avatar Mar 04 '22 13:03 mchylek

@eiriktsarpalis could you take a look on this PR? 😄

mchylek avatar Mar 18 '22 07:03 mchylek

@eiriktsarpalis could you take a look on latest changes? Thanks!

mchylek avatar Mar 25 '22 13:03 mchylek

I'm pretty swamped with regular work at the moment, I'll take a look at some later point. Sorry!

eiriktsarpalis avatar Mar 31 '22 10:03 eiriktsarpalis