Alternator icon indicating copy to clipboard operation
Alternator copied to clipboard

Need to add rangekey support for Tables

Open tnb115 opened this issue 13 years ago • 6 comments

Currently the Table model doesn't support the RangeKey

tnb115 avatar Aug 30 '12 20:08 tnb115

Is this feature actively being worked on? (I'm not sure I have time to work on this at the moment, but wanted to see what the status was in case I had time in the future.)

thughes avatar Sep 11 '12 20:09 thughes

Not in the next couple of weeks since we don't need that for our project and it involves some restructuring of the classes. If you find some time feel free to go for it :-)

tnb115 avatar Sep 11 '12 20:09 tnb115

I have a pending Pull Request where I added this support. As tnbredillet indicated, it required adding another nesting layer to the Table.items collection via a new ItemRangeGroup class. It also required reworking various AlternatorDBHandler methods to be aware of the extra nesting.

If you want to experiment with this revision, you can obtain it from my forked repository branch 'range-key-support':

https://github.com/rrutt/Alternator/tree/range-key-support

rrutt avatar Oct 21 '12 17:10 rrutt

Pull request granted, need to revise code.

mboudreau avatar Oct 22 '12 15:10 mboudreau

Pull request 49 from *thughes" provided "Fix deleting item with range key".

https://github.com/mboudreau/Alternator/pull/49

I have also discovered that query with a RangeCondition against a table with a numeric Range Key was also failing. I have this fixed in my own forked repository. I will be preparing a branch for submission as a Pull Request sometime this week.

rrutt avatar Jan 29 '13 14:01 rrutt

I submitted my fixes for .query against a table with a numeric Range Key as Pull request 50:

https://github.com/mboudreau/Alternator/pull/50

rrutt avatar Jan 31 '13 18:01 rrutt