file-source icon indicating copy to clipboard operation
file-source copied to clipboard

Require node engine versions that have `Promise` natively?

Open hryanjones opened this issue 8 years ago • 1 comments

I was trying to run shp2json from your shapefile package and I ran into an error that Promise is not defined in file-source:

/usr/local/lib/node_modules/shapefile/node_modules/path-source/node_modules/file-source/index.js:7
  return new Promise(function(resolve, reject) {
             ^
ReferenceError: Promise is not defined

According to this stackoverflow answer it looks like Node didn't add Promise until version 0.12, and I'm stuck on an earlier version because it's the version we use to build our package:

$ node --version
v0.10.25

Would it be possible to update the package.json to specify the engines supported, so it'll fail at install time? It looks like this is the way to do that.

Thanks, Ryan

hryanjones avatar Jan 25 '17 01:01 hryanjones

Do you want to send a pull request?

mbostock avatar Jan 25 '17 18:01 mbostock