kissfft icon indicating copy to clipboard operation
kissfft copied to clipboard

Pull Request for Arduino Support

Open pschatzmann opened this issue 3 years ago • 6 comments

I was wondering if you would accept a pull request to add Arduino Support which contains the following changes

  • new file library.properties in the root directory.
  • new file kiss_arduino_config.h in the root directory where we can define FIXED_POINT.
  • the following change in kiss_fft.h to use the configuration
#if defined(ARDUINO) && !defined(IGNORE_ARDUINO_CONFIG)
#include "kiss_arduino_config.h"
#endif

With these changes the project can be used as Arduino library...

pschatzmann avatar Apr 19 '22 19:04 pschatzmann

I saw your fork. Please rename IGNORE_ARDUINO_CONFIG to a more project-specific name like KISSFFT_IGNORE_ARDUINO_CONFIG.

dizcza avatar Apr 11 '23 07:04 dizcza

... and putting yourself as the author discredits Mark's invaluable work.

dizcza avatar Apr 12 '23 12:04 dizcza

Done, but I did not get any answer from mborgerding, so I did not submit any pull request. I planned to update library.properties after getting an answer, which unfortunately never happend.

pschatzmann avatar Apr 12 '23 13:04 pschatzmann

Yeah, the support seems to be abandoned, as I've also seen another PR here that I wanted to be merged.

Anyhow, I linked your library against a copy-pasted kissfft lib from this project and it worked out fine.

dizcza avatar Apr 12 '23 13:04 dizcza

Cool, my major goal was to be able to provide some alternative implementations in my Arduino Audio Tools, so that we can use one common API. You might also have a look at esp-dsp from Espressif...

pschatzmann avatar Apr 12 '23 13:04 pschatzmann

Actually, I had a look at your audio tools repo a few months ago when searching for a simple solution to save audio from INMP441. I hadn't noticed that you also provide FFT support and even some benches.

So AudioESP32FFT appears as the winner, doesn't it? That's interesting that it supports both ARM and ESP platforms... I may have a closer look.

Ah, I should have read it to the end:

AudioRealFFT seems to perform better, with bigger values!

Got it.

dizcza avatar Apr 12 '23 14:04 dizcza