Maxime Boissonneault
Maxime Boissonneault
Ok, this is what I had to do to make our use case work again: https://github.com/ComputeCanada/easybuild-easyblocks/commit/7185b5211c2f180c76ecc7bbebcf743fde1501e7 I can open a PR with the relevant code if it is useful
Hum, we have not hit this, but we don't ever use `PYTHONPATH`, we use `EBPYTHONPREFIXES` with the `sitecustomize.py`, so maybe we are immune to this change ?
I tried this to see if it would keep the files between each run `keeppreviousinstall = True` But it does not seem to do the trick :/
I see @akesandgren was the author of the `tensorrt.py` EasyBlock, so tagging you too.
The issue is caused by this line : https://github.com/ComputeCanada/easybuild-easyblocks/blob/computecanada-master/easybuild/easyblocks/generic/binary.py#L109 which can only be removed with Python 3.8's new `dirs_exist_ok` for the `shutil.copytree` This means that the option `keeppreviousinstall = True`...
For my specific use case (TensorRT), I worked around the issue by bypassing this codepath by specifying a custom `install_cmd` : https://github.com/ComputeCanada/easybuild-easyconfigs/blob/6b883300c207014bf1fe7739f749dd9906401fec/easybuild/easyconfigs/t/TensorRT/TensorRT-6.0.1.5-CUDAcore-10.1.243.eb#L15
The idea is being able to add something like this in an `exts_list` for a `PythonBundle`: ``` ('CacheControl', '0.12.10', { 'fix_python_shebang_for': ['bin/doesitcache'], }), ``` or ``` ('wheel', '0.37.1', { 'fix_python_shebang_for':...
PR https://github.com/easybuilders/easybuild-easyblocks/pull/2720 addresses some of the same points as this PR, but not all of them. In particular, it does not disable tests for AmberTools, and so the build of...
Mmm, I don't know. Patches have to be maintained from version to version. If there are configure flags that allow us to do the same work, I would rather not...