Maxime Boissonneault

Results 110 comments of Maxime Boissonneault

@boegel, what kind of test would you like to see ? I'm not sure how to test this.

I'm sorry, I don't have time to work on tests at the moment.

So far, I have assumed that one had either checksums in the EasyConfig file *or* a `checksums.json` file. The `checksums.json` file mechanism *only* takes effect if there are no checksums...

@boegel, do you think we need to address `--new-pr` and the `--inject-checksums-to-json` when using `--try-software-version` issue in this PR ?

+1 Python Wheels are awesome!

My main goal was to avoid duplicating this code in easyblocks : ``` [mboisson@build-node easybuild]$ grep -r 'pyshortver =' . ./easyblocks/b/blender.py: pyshortver = '.'.join(get_software_version('Python').split('.')[:2]) ./easyblocks/generic/pythonpackage.py: pyshortver = '.'.join(python_version.split('.')[:2]) ./easyblocks/o/openbabel.py: pyshortver...

Once this get merged, I can make a PR for easyblocks to replace these : ``` easybuild/easyblocks/b/blender.py: pyshortver = '.'.join(get_software_version('Python').split('.')[:2]) easybuild/easyblocks/d/dolfin.py: pyver = '.'.join(get_software_version('Python').split('.')[:2]) easybuild/easyblocks/g/gamess_us.py: fortran_ver = '.'.join(get_software_version('GCC').split('.')[:2]) easybuild/easyblocks/n/namd.py: tclversion...

I see that there are similar patterns that do not use get_software_version : ``` [mboisson@build-node easybuild-easyblocks]$ grep -r "'\.'.join" easybuild | grep -v get_software_version easybuild/easyblocks/a/abaqus.py: custom_paths['dirs'].append('%s-%s' % ('.'.join(verparts[0:2]), verparts[2])) easybuild/easyblocks/e/easybuildmeta.py:...

🤔 How is a PR merged in 2017 supposed to be fixing an issue reported in 2020 ?