[v5] "Move selected (or active) tabs to X panel" does not consider non-tab panels as panels like "Switch to first panel"

[megamorphg]

Steps to reproduce

So I finally started using panels a little bit and setup some keybindings and found out the "Move selected (or active) tabs to X panel" does not consider non-tab panels as panels like "Switch to first panel" does.

Setup:

• Open Firefox in new profile
• Install Sidebery and install addon settings
• Create 2 panels and arrange history panel before tab panel:
• Create keybindings for switching panels and moving tabs to panels:

Test:

• Use keybinding to switch panels from 1-4. Notice that the Bookmarks and History are considered as "panels"
• Use keybinding to move panels from 1-4. Notice that the Bookmarks and History are not considered as "panels"

Expected behavior

Switching panels and moving panels have a consistent consideration of what "panels" are.

Actually, I like the idea that bookmarks and history are considered as "panels" so do not want to lose that keybinding to easily open those panels. So ideally I would just like "Move selected (or active) tabs to X panel" to behave the same way as "Switch to first panel"... however, it should just do nothing if moving a tab to a non-tab Panel. It should not try to randomly create a bookmark or history entry... though that could have some useful functionality in future of searching for that selected tab in bookmark/history.

Actual behavior

Keybinding "Move selected (or active) tabs to X panel" does not consider non-tab panels as panels like "Switch to first panel" does.

Debug info

Addon data

{ "settings": { "nativeScrollbars": true, "nativeScrollbarsThin": false, "nativeScrollbarsLeft": true, "selWinScreenshots": true, "updateSidebarTitle": true, "markWindow": false, "markWindowPreface": "[SB] ", "ctxMenuNative": false, "ctxMenuRenderInact": true, "ctxMenuRenderIcons": true, "ctxMenuIgnoreContainers": "", "navBarLayout": "vertical", "navBarInline": false, "navBarSide": "left", "hideAddBtn": false, "hideSettingsBtn": false, "navBtnCount": true, "hideEmptyPanels": true, "navActTabsPanelLeftClickAction": "new_tab", "navActBookmarksPanelLeftClickAction": "scroll", "navTabsPanelMidClickAction": "discard", "navBookmarksPanelMidClickAction": "convert", "navSwitchPanelsWheel": true, "groupLayout": "list", "skipEmptyPanels": true, "dndTabAct": true, "dndTabActDelay": 5000, "dndTabActMod": "alt", "dndExp": "pointer", "dndExpDelay": 50, "dndExpMod": "alt", "dndOutside": "data", "searchBarMode": "static", "warnOnMultiTabClose": "collapsed", "activateLastTabOnPanelSwitching": true, "showTabRmBtn": true, "hideInact": true, "activateAfterClosing": "prev", "activateAfterClosingGlobal": true, "activateAfterClosingNoFolded": true, "activateAfterClosingNoDiscarded": false, "askNewBookmarkPlace": true, "tabsRmUndoNote": true, "nativeHighlight": true, "tabsUnreadMark": true, "tabsUpdateMark": "all", "tabsReloadLimit": 3, "tabsReloadLimitNotif": false, "showNewTabBtns": true, "newTabBarPosition": "bottom", "tabsPanelSwitchActMove": true, "tabsUrlInTooltip": "full", "openSubPanelOnMouseHover": false, "colorizeTabs": true, "colorizeTabsSrc": "domain", "moveNewTabPin": "end", "moveNewTabParent": "first_child", "moveNewTabParentActPanel": true, "moveNewTab": "none", "moveNewTabActivePin": "start", "pinnedTabsPosition": "left", "pinnedTabsList": true, "pinnedAutoGroup": false, "tabsTree": true, "groupOnOpen": true, "tabsTreeLimit": "none", "hideFoldedTabs": true, "autoFoldTabs": false, "autoFoldTabsExcept": 5, "autoExpandTabs": false, "rmChildTabs": "folded", "tabsChildCount": true, "tabsLvlDots": true, "discardFolded": true, "discardFoldedDelay": 10, "discardFoldedDelayUnit": "min", "tabsTreeBookmarks": true, "treeRmOutdent": "first_child", "colorizeTabsBranches": false, "colorizeTabsBranchesSrc": "domain", "warnOnMultiBookmarkDelete": "any", "autoCloseBookmarks": false, "autoRemoveOther": false, "highlightOpenBookmarks": true, "activateOpenBookmarkTab": true, "showBookmarkLen": true, "bookmarksRmUndoNote": true, "loadBookmarksOnDemand": true, "pinOpenedBookmarksFolder": true, "loadHistoryOnDemand": true, "fontSize": "xxl", "animations": false, "animationSpeed": "fast", "theme": "compact", "colorScheme": "ff", "sidebarCSS": false, "groupCSS": false, "snapNotify": true, "snapExcludePrivate": false, "snapInterval": 5, "snapIntervalUnit": "hr", "snapLimit": 50, "snapLimitUnit": "day", "hScrollAction": "switch_act_tabs", "navSwitchPanelsDelay": 128, "scrollThroughTabs": "panel", "scrollThroughVisibleTabs": true, "scrollThroughTabsSkipDiscarded": true, "scrollThroughTabsExceptOverflow": false, "scrollThroughTabsCyclic": true, "scrollThroughTabsScrollArea": -90, "autoMenuMultiSel": true, "multipleMiddleClose": true, "longClickDelay": 500, "wheelThreshold": false, "wheelThresholdX": 10, "wheelThresholdY": 60, "tabDoubleClick": "none", "tabsSecondClickActPrev": true, "shiftSelAct": true, "activateOnMouseUp": true, "tabLongLeftClick": "none", "tabLongRightClick": "duplicate", "tabCloseMiddleClick": "discard", "tabsPanelLeftClickAction": "none", "tabsPanelDoubleClickAction": "tab", "tabsPanelRightClickAction": "menu", "tabsPanelMiddleClickAction": "undo", "newTabMiddleClickAction": "new_child", "bookmarksLeftClickAction": "open_in_new", "bookmarksLeftClickActivate": true, "bookmarksLeftClickPos": "after", "bookmarksMidClickAction": "open_in_new", "bookmarksMidClickActivate": false, "bookmarksMidClickPos": "default", "syncName": "Firefox--X470-Stable", "syncSaveSettings": true, "syncSaveCtxMenu": true, "syncSaveStyles": true, "syncSaveKeybindings": true }, "permissions": { "allUrls": true, "tabHide": true, "clipboardWrite": true, "webRequest": true, "webRequestBlocking": true }, "storage": { "size": "14.6 kb", "props": { "containers": "3.78 kb", "contextMenu": "1.39 kb", "favDomains": "70 b", "favHashes": "10 b", "favicons": "502 b", "prevTabsDataCache": "379 b", "profileID": "14 b", "settings": "3.62 kb", "sidebar": "4.29 kb", "tabsDataCache": "393 b", "ver": "10 b" } }, "sidebar": { "panels": { "bookmarks": { "type": 1, "id": "bookmarks", "name": "len: 9", "iconSVG": "icon_bookmarks", "iconIMGSrc": "", "iconIMG": "", "color": "toolbar", "lockedPanel": false, "tempMode": false, "skipOnSwitching": false, "rootId": "root________", "viewMode": "tree", "autoConvert": false }, "history": { "type": 4, "id": "history", "name": "len: 7", "color": "toolbar", "iconSVG": "icon_clock", "tempMode": false, "lockedPanel": false, "skipOnSwitching": false, "viewMode": "history" }, "oPvtGQIvR9Am": { "type": 2, "id": "oPvtGQIvR9Am", "name": "len: 7", "color": "toolbar", "iconSVG": "icon_tabs", "iconIMGSrc": "", "iconIMG": "", "lockedPanel": false, "skipOnSwitching": false, "noEmpty": false, "newTabCtx": "none", "dropTabCtx": "none", "moveTabCtx": "none", "moveTabCtxNoChild": true, "urlRulesActive": false, "urlRules": "", "bookmarksFolderId": -1, "newTabBtns": [] }, "firefox-default": { "type": 2, "id": "firefox-default", "name": "len: 6", "color": "blue", "iconSVG": "icon_tabs", "iconIMGSrc": "", "iconIMG": "", "lockedPanel": false, "skipOnSwitching": false, "noEmpty": false, "newTabCtx": "none", "dropTabCtx": "none", "moveTabCtx": "none", "moveTabCtxNoChild": true, "urlRulesActive": false, "urlRules": "", "bookmarksFolderId": "v1-NPzNuzw9d", "newTabBtns": [] }, "77PJQY1X7zAm": { "type": 2, "id": "77PJQY1X7zAm", "name": "len: 6", "color": "turquoise", "iconSVG": "icon_tabs", "iconIMGSrc": "", "iconIMG": "", "lockedPanel": false, "skipOnSwitching": false, "noEmpty": false, "newTabCtx": "none", "dropTabCtx": "none", "moveTabCtx": "none", "moveTabCtxNoChild": true, "urlRulesActive": false, "urlRules": "", "bookmarksFolderId": -1, "newTabBtns": [] }, "Gi2njE8Dnlan": { "type": 2, "id": "Gi2njE8Dnlan", "name": "len: 6", "color": "green", "iconSVG": "icon_tabs", "iconIMGSrc": "", "iconIMG": "", "lockedPanel": false, "skipOnSwitching": false, "noEmpty": false, "newTabCtx": "none", "dropTabCtx": "none", "moveTabCtx": "none", "moveTabCtxNoChild": true, "urlRulesActive": false, "urlRules": "", "bookmarksFolderId": -1, "newTabBtns": [] }, "wdzkA8VBChsL": { "type": 2, "id": "wdzkA8VBChsL", "name": "len: 6", "color": "yellow", "iconSVG": "icon_tabs", "iconIMGSrc": "", "iconIMG": "", "lockedPanel": false, "skipOnSwitching": false, "noEmpty": false, "newTabCtx": "none", "dropTabCtx": "none", "moveTabCtx": "none", "moveTabCtxNoChild": true, "urlRulesActive": false, "urlRules": "", "bookmarksFolderId": -1, "newTabBtns": [] }, "Ak5q9G_7_hsL": { "type": 2, "id": "Ak5q9G_7_hsL", "name": "len: 6", "color": "orange", "iconSVG": "icon_tabs", "iconIMGSrc": "", "iconIMG": "", "lockedPanel": false, "skipOnSwitching": false, "noEmpty": false, "newTabCtx": "none", "dropTabCtx": "none", "moveTabCtx": "none", "moveTabCtxNoChild": true, "urlRulesActive": false, "urlRules": "", "bookmarksFolderId": -1, "newTabBtns": [] }, "tIpuOF5MEisL": { "type": 2, "id": "tIpuOF5MEisL", "name": "len: 6", "color": "red", "iconSVG": "icon_tabs", "iconIMGSrc": "", "iconIMG": "", "lockedPanel": false, "skipOnSwitching": false, "noEmpty": false, "newTabCtx": "none", "dropTabCtx": "none", "moveTabCtx": "none", "moveTabCtxNoChild": true, "urlRulesActive": false, "urlRules": "", "bookmarksFolderId": -1, "newTabBtns": [] }, "sIhAINvH6isL": { "type": 2, "id": "sIhAINvH6isL", "name": "len: 6", "color": "pink", "iconSVG": "icon_tabs", "iconIMGSrc": "", "iconIMG": "", "lockedPanel": false, "skipOnSwitching": false, "noEmpty": false, "newTabCtx": "none", "dropTabCtx": "none", "moveTabCtx": "none", "moveTabCtxNoChild": true, "urlRulesActive": false, "urlRules": "", "bookmarksFolderId": -1, "newTabBtns": [] }, "nNIxD1ytsrsL": { "type": 2, "id": "nNIxD1ytsrsL", "name": "len: 6", "color": "purple", "iconSVG": "icon_tabs", "iconIMGSrc": "", "iconIMG": "", "lockedPanel": false, "skipOnSwitching": false, "noEmpty": false, "newTabCtx": "none", "dropTabCtx": "none", "moveTabCtx": "none", "moveTabCtxNoChild": true, "urlRulesActive": false, "urlRules": "", "bookmarksFolderId": -1, "newTabBtns": [] }, "l57xRuBBu53N": { "type": 2, "id": "l57xRuBBu53N", "name": "len: 7", "color": "toolbar", "iconSVG": "icon_tabs", "iconIMGSrc": "", "iconIMG": "", "lockedPanel": false, "skipOnSwitching": false, "noEmpty": false, "newTabCtx": "none", "dropTabCtx": "none", "moveTabCtx": "none", "moveTabCtxNoChild": true, "urlRulesActive": false, "urlRules": "", "bookmarksFolderId": -1, "newTabBtns": [] } }, "nav": [ "search", "bookmarks", "history", "sd-XqcSsH9U_eJG", "sp-arYkJj_-YW8z", "sd-0RTG0nRBEA0E", "oPvtGQIvR9Am", "firefox-default", "77PJQY1X7zAm", "Gi2njE8Dnlan", "wdzkA8VBChsL", "Ak5q9G_7_hsL", "tIpuOF5MEisL", "sIhAINvH6isL", "nNIxD1ytsrsL", "l57xRuBBu53N", "sd-LG6U0Z8jb4ZE", "sp-0", "sd-0Ruoc0-VQ28E", "add_tp", "sd-uGNt_zOfLHJG", "remute_audio_tabs", "sd-wfp6yaNpcIJG", "collapse", "sd-apkhtLfLJqBF", "create_snapshot", "sd-Rrd5zW7r0JJG", "settings" ] }, "containers": [ { "id": "firefox-container-1", "cookieStoreId": "firefox-container-1", "name": "8", "icon": "...", "color": "blue", "colorCode": "#37adff", "proxified": false, "proxy": null, "includeHostsActive": true, "includeHosts": "34", "excludeHostsActive": false, "excludeHosts": "", "userAgentActive": false, "userAgent": "" }, { "id": "firefox-container-2", "cookieStoreId": "firefox-container-2", "name": "4", "icon": "...", "color": "orange", "colorCode": "#37adff", "proxified": false, "proxy": null, "includeHostsActive": true, "includeHosts": "30", "excludeHostsActive": false, "excludeHosts": "", "userAgentActive": false, "userAgent": "" }, { "id": "firefox-container-3", "cookieStoreId": "firefox-container-3", "name": "7", "icon": "...", "color": "green", "colorCode": "#37adff", "proxified": false, "proxy": null, "includeHostsActive": true, "includeHosts": "33", "excludeHostsActive": false, "excludeHosts": "", "userAgentActive": false, "userAgent": "" }, { "id": "firefox-container-4", "cookieStoreId": "firefox-container-4", "name": "8", "icon": "...", "color": "pink", "colorCode": "#37adff", "proxified": false, "proxy": null, "includeHostsActive": true, "includeHosts": "34", "excludeHostsActive": false, "excludeHosts": "", "userAgentActive": false, "userAgent": "" }, { "id": "firefox-container-6", "cookieStoreId": "firefox-container-6", "name": "3", "icon": "...", "color": "toolbar", "colorCode": "#37adff", "proxified": false, "proxy": null, "includeHostsActive": true, "includeHosts": "29", "excludeHostsActive": false, "excludeHosts": "", "userAgentActive": false, "userAgent": "" }, { "id": "firefox-container-7", "cookieStoreId": "firefox-container-7", "name": "21", "icon": "...", "color": "toolbar", "colorCode": "#37adff", "proxified": false, "proxy": null, "includeHostsActive": true, "includeHosts": "47", "excludeHostsActive": false, "excludeHosts": "", "userAgentActive": false, "userAgent": "" }, { "id": "firefox-container-8", "cookieStoreId": "firefox-container-8", "name": "11", "icon": "...", "color": "blue", "colorCode": "#37adff", "proxified": false, "proxy": null, "includeHostsActive": true, "includeHosts": "37", "excludeHostsActive": false, "excludeHosts": "", "userAgentActive": false, "userAgent": "" }, { "id": "firefox-container-9", "cookieStoreId": "firefox-container-9", "name": "4", "icon": "...", "color": "yellow", "colorCode": "#37adff", "proxified": false, "proxy": null, "includeHostsActive": false, "includeHosts": "", "excludeHostsActive": false, "excludeHosts": "", "userAgentActive": false, "userAgent": "" }, { "id": "firefox-container-10", "cookieStoreId": "firefox-container-10", "name": "7", "icon": "...", "color": "purple", "colorCode": "#37adff", "proxified": false, "proxy": null, "includeHostsActive": false, "includeHosts": "", "excludeHostsActive": false, "excludeHosts": "", "userAgentActive": false, "userAgent": "" }, { "id": "firefox-container-11", "cookieStoreId": "firefox-container-11", "name": "2", "icon": "...", "color": "toolbar", "colorCode": "#37adff", "proxified": false, "proxy": null, "includeHostsActive": true, "includeHosts": "47", "excludeHostsActive": false, "excludeHosts": "", "userAgentActive": false, "userAgent": "" }, { "id": "firefox-container-12", "cookieStoreId": "firefox-container-12", "name": "2", "icon": "...", "color": "blue", "colorCode": "#37adff", "proxified": false, "proxy": null, "includeHostsActive": true, "includeHosts": "28", "excludeHostsActive": false, "excludeHosts": "", "userAgentActive": false, "userAgent": "" } ], "windows": [ { "state": "normal", "incognito": false, "tabsCount": 4 } ], "bookmarks": { "bookmarksCount": 5, "foldersCount": 5, "separatorsCount": 0, "maxDepth": 2 } }

[mbnuqw]

Yeah, it's a UX/UI issue. I'll probably either update the 'moving' keybindings to "Move selected tabs to N tabs-panel" or create multiple keybindings with selection of target panel like: "Move selected tabs to: [Select input with a list of available tab panels]"
"Move selected tabs to: [Select input with a list of available tab panels]"
...etc (maybe 10 is enough)

[megamorphg]

@mbnuqw that makes sense and would make it so that the "switch panel" can still be used to switch to the bookmarks/history (since we do not have specific keybindings for that).