"Hiding tabs of inactive panels" does not work right when switching panels

[shemgaw]

Steps to reproduce

Hi, “Hiding tabs of inactive panels” does not work right when switching panels. Active tabs are moved to the newly selected panel. Instead, a “new tab” should be expected, and the active tab should stay in the old panel. Check out the behaviour on the attached video. I am switching panels with a mouse click (to be configured in the Sidebery settings). It disturbs work quite significantly and brings chaos to the tabs and panels. Anyone else experiencing that? https://user-images.githubusercontent.com/112238816/187019558-9e1e847f-2611-47c7-af4b-4a0075ccf4f2.mp4

Expected behavior

"New tab" tab opens or homepage active tab stays in the panel 1

Actual behavior

Active tab in panel 1 is moved to panel 2

Debug info

Addon data

{ "settings": { "version": "4.10.1", "nativeScrollbars": false, "selWinScreenshots": true, "tabsCheck": true, "tabsFix": "notify", "markWindow": false, "markWindowPreface": "[Sidebery] ", "ctxMenuNative": false, "autoHideCtxMenu": "none", "ctxMenuRenderInact": true, "ctxMenuIgnoreContainers": "", "navBarLayout": "vertical", "navBarInline": false, "hideAddBtn": false, "hideSettingsBtn": false, "navBtnCount": false, "hideEmptyPanels": false, "navActTabsPanelLeftClickAction": "none", "navActBookmarksPanelLeftClickAction": "none", "navMidClickAction": "none", "navSwitchPanelsWheel": true, "groupLayout": "list", "skipEmptyPanels": false, "dndTabAct": true, "dndTabActDelay": 750, "dndTabActMod": "none", "dndExp": "pointer", "dndExpDelay": 0, "dndExpMod": "none", "stateStorage": "session", "warnOnMultiTabClose": "collapsed", "activateOnMouseUp": true, "activateLastTabOnPanelSwitching": true, "showTabRmBtn": true, "showTabCtx": true, "hideInact": true, "activateAfterClosing": "prev_act", "activateAfterClosingPrevRule": "visible", "activateAfterClosingNextRule": "tree", "activateAfterClosingGlobal": true, "activateAfterClosingNoFolded": true, "activateAfterClosingNoDiscarded": true, "shiftSelAct": true, "askNewBookmarkPlace": true, "tabsRmUndoNote": true, "nativeHighlight": true, "tabsUnreadMark": true, "tabsReloadLimit": 5, "tabsReloadLimitNotif": true, "tabsPanelSwitchActMove": true, "moveNewTabPin": "start", "moveNewTabParent": "first_child", "moveNewTabParentActPanel": false, "moveNewTab": "none", "pinnedTabsPosition": "panel", "pinnedTabsList": true, "pinnedAutoGroup": false, "tabsTree": false, "groupOnOpen": true, "tabsTreeLimit": "none", "hideFoldedTabs": false, "autoFoldTabs": false, "autoFoldTabsExcept": "none", "autoExpandTabs": false, "rmChildTabs": "none", "tabsChildCount": true, "tabsLvlDots": false, "discardFolded": false, "discardFoldedDelay": 0, "discardFoldedDelayUnit": "sec", "tabsTreeBookmarks": true, "treeRmOutdent": "branch", "bookmarksPanel": false, "warnOnMultiBookmarkDelete": "collapsed", "openBookmarkNewTab": false, "midClickBookmark": "open_new_tab", "actMidClickTab": false, "autoCloseBookmarks": false, "autoRemoveOther": false, "highlightOpenBookmarks": false, "activateOpenBookmarkTab": false, "showBookmarkLen": false, "bookmarksRmUndoNote": true, "fontSize": "xxl", "bgNoise": true, "animations": true, "animationSpeed": "slow", "theme": "default", "style": "dark", "sidebarCSS": true, "groupCSS": false, "snapNotify": true, "snapExcludePrivate": false, "snapInterval": 0, "snapIntervalUnit": "min", "snapLimit": 0, "snapLimitUnit": "snap", "hScrollThroughPanels": true, "scrollThroughTabs": "panel", "scrollThroughVisibleTabs": false, "scrollThroughTabsSkipDiscarded": false, "scrollThroughTabsExceptOverflow": true, "scrollThroughTabsCyclic": false, "tabDoubleClick": "new_child", "tabLongLeftClick": "reload", "tabLongRightClick": "none", "tabsPanelLeftClickAction": "prev", "tabsPanelDoubleClickAction": "tab", "tabsPanelRightClickAction": "next", "tabsPanelMiddleClickAction": "tab", "syncName": "", "syncSaveSettings": false, "syncSaveCtxMenu": false, "syncSaveStyles": false, "syncAutoApply": false }, "permissions": { "allUrls": true, "tabHide": true, "actualAllUrls": true, "actualTabHide": true }, "storage": { "size": "317.6 kb", "props": { "containers_v4": "1 kb", "expandedBookmarks": "18 b", "favAutoCleanTime": "10 b", "favUrls": "6 kb", "favicons": "300.6 kb", "lastSnapTime": "13 b", "panelIndex": "1 b", "panels_v4": "3.6 kb", "prevTabsData_v4": "1.5 kb", "profileID": "14 b", "settings": "2.8 kb", "sidebarCSS": "554 b", "snapshots_v4": "2 b", "tabsData_v4": "1 kb" } }, "panels": [ { "type": "bookmarks", "id": "bookmarks", "cookieStoreId": "bookmarks", "name": 9, "icon": "...", "bookmarks": true, "lockedPanel": false, "skipOnSwitching": false }, { "type": "default", "id": "firefox-default", "name": 7, "icon": "...", "cookieStoreId": "firefox-default", "lockedTabs": false, "lockedPanel": false, "skipOnSwitching": false, "noEmpty": false, "newTabCtx": "none", "dropTabCtx": "none", "moveTabCtx": "none", "moveTabCtxNoChild": true }, { "type": "tabs", "id": "cTPThllgs3Ho", "name": 11, "icon": "...", "color": "...", "customIconSrc": "", "customIcon": "", "lockedTabs": false, "lockedPanel": false, "skipOnSwitching": false, "noEmpty": true, "newTabCtx": "none", "dropTabCtx": "none", "moveTabCtx": "none", "moveTabCtxNoChild": true, "urlRulesActive": false, "urlRules": "" }, { "type": "tabs", "id": "rdsxvmftb5Ho", "name": 11, "icon": "...", "color": "...", "customIconSrc": "", "customIcon": "", "lockedTabs": false, "lockedPanel": false, "skipOnSwitching": false, "noEmpty": false, "newTabCtx": "none", "dropTabCtx": "none", "moveTabCtx": "none", "moveTabCtxNoChild": true, "urlRulesActive": false, "urlRules": "" }, { "type": "tabs", "id": "TsfZptMQD5Ho", "name": 11, "icon": "...", "color": "...", "customIconSrc": "", "customIcon": "", "lockedTabs": false, "lockedPanel": false, "skipOnSwitching": false, "noEmpty": false, "newTabCtx": "none", "dropTabCtx": "none", "moveTabCtx": "none", "moveTabCtxNoChild": true, "urlRulesActive": false, "urlRules": "" }, { "type": "tabs", "id": "ioePLepcN5Ho", "name": 11, "icon": "...", "color": "...", "customIconSrc": "", "customIcon": "", "lockedTabs": false, "lockedPanel": false, "skipOnSwitching": false, "noEmpty": false, "newTabCtx": "none", "dropTabCtx": "none", "moveTabCtx": "none", "moveTabCtxNoChild": true, "urlRulesActive": false, "urlRules": "" }, { "type": "tabs", "id": "Su9hyCNM65Ho", "name": 11, "icon": "...", "color": "...", "customIconSrc": "", "customIcon": "", "lockedTabs": false, "lockedPanel": false, "skipOnSwitching": false, "noEmpty": false, "newTabCtx": "none", "dropTabCtx": "none", "moveTabCtx": "none", "moveTabCtxNoChild": true, "urlRulesActive": false, "urlRules": "" }, { "type": "tabs", "id": "aGlF0cU2f6Ho", "name": 11, "icon": "...", "color": "...", "customIconSrc": "", "customIcon": "", "lockedTabs": false, "lockedPanel": false, "skipOnSwitching": false, "noEmpty": false, "newTabCtx": "none", "dropTabCtx": "none", "moveTabCtx": "none", "moveTabCtxNoChild": true, "urlRulesActive": false, "urlRules": "" }, { "type": "tabs", "id": "hmVJ5c8Hq6Ho", "name": 11, "icon": "...", "color": "...", "customIconSrc": "", "customIcon": "", "lockedTabs": false, "lockedPanel": false, "skipOnSwitching": false, "noEmpty": false, "newTabCtx": "none", "dropTabCtx": "none", "moveTabCtx": "none", "moveTabCtxNoChild": true, "urlRulesActive": false, "urlRules": "" }, { "type": "tabs", "id": "U5Khw27WD6Ho", "name": 11, "icon": "...", "color": "...", "customIconSrc": "", "customIcon": "", "lockedTabs": false, "lockedPanel": false, "skipOnSwitching": false, "noEmpty": false, "newTabCtx": "none", "dropTabCtx": "none", "moveTabCtx": "none", "moveTabCtxNoChild": true, "urlRulesActive": false, "urlRules": "" }, { "type": "tabs", "id": "H2p4USa-oeIo", "name": 11, "icon": "...", "color": "...", "customIconSrc": "", "customIcon": "", "lockedTabs": false, "lockedPanel": false, "skipOnSwitching": false, "noEmpty": false, "newTabCtx": "none", "dropTabCtx": "none", "moveTabCtx": "none", "moveTabCtxNoChild": true, "urlRulesActive": false, "urlRules": "" }, { "type": "tabs", "id": "aStliEhCCeIo", "name": 12, "icon": "...", "color": "...", "customIconSrc": "", "customIcon": "", "lockedTabs": false, "lockedPanel": false, "skipOnSwitching": false, "noEmpty": false, "newTabCtx": "none", "dropTabCtx": "none", "moveTabCtx": "none", "moveTabCtxNoChild": true, "urlRulesActive": false, "urlRules": "" } ], "containers": [ { "id": "firefox-container-1", "name": 8, "icon": "...", "color": "...", "proxified": false, "proxy": null, "includeHostsActive": false, "includeHosts": "", "excludeHostsActive": false, "excludeHosts": "", "userAgentActive": false, "userAgent": "" }, { "id": "firefox-container-2", "name": 4, "icon": "...", "color": "...", "proxified": false, "proxy": null, "includeHostsActive": false, "includeHosts": "", "excludeHostsActive": false, "excludeHosts": "", "userAgentActive": false, "userAgent": "" }, { "id": "firefox-container-3", "name": 7, "icon": "...", "color": "...", "proxified": false, "proxy": null, "includeHostsActive": false, "includeHosts": "", "excludeHostsActive": false, "excludeHosts": "", "userAgentActive": false, "userAgent": "" }, { "id": "firefox-container-4", "name": 8, "icon": "...", "color": "...", "proxified": false, "proxy": null, "includeHostsActive": false, "includeHosts": "", "excludeHostsActive": false, "excludeHosts": "", "userAgentActive": false, "userAgent": "" } ], "cssVars": "TypeError: can't convert undefined to object", "sidebarCSSLen": 523, "windows": [ { "state": "maximized", "incognito": false, "tabsCount": 10 } ], "bookmarks": { "bookmarksCount": 9, "foldersCount": 5, "separatorsCount": 0, "maxDepth": 2 } }

Logs

no message appeared

[albino1]

I could be wrong, but I think it's because you have to have at least one visible tab. Put a blank newtab in each of those panels and I think the tab you're on will stay where it was.

[shemgaw]

To be honest, I haven't showed you guys the whole messed up behaviour afterwards, especially when you switch tabs, open new tabs and add tabs count, it becomes even more bizarre :). I'll try tomorrow. Nevertheless, it disqualifies Mozilla to replace Opera's Workspaces atm, which works perfectly fine there. Shame, I thought I'll get back to my old'n'good Mozilla years back time when I was a proper fanboy

[mbnuqw]

Fixed from v5.0.0