sidebery icon indicating copy to clipboard operation
sidebery copied to clipboard

Ctrl+click not working as intended on MacOS

Open d9i opened this issue 3 years ago • 1 comments

Steps to reproduce

  1. Install Firefox with Sidebery on MacOS
  2. ctrl+click on a tab
  3. move the mouse cursor

Expected behavior

The tab is selected, but the browser doesn't switch to that tab. I can ctrl+click again on a different tab to add that to my selection.

Actual behavior

A range of tabs is selected, following my cursor. The only way to deselect these tabs is by clicking the right mouse button on a tab. Happy to share a video of this behavior if it's helpful.

I think what's going on here is that MacOS interprets Ctrl+click as a Right-click. IMO a good fix would be to switch the keybinding for Mac to Cmd+click (the most common "select multiple" keybind on MacOS) - or even give us the option to change the keybinding in the settings if that's easier.

Debug info

Addon data

{ "settings": { "version": "4.10.1", "nativeScrollbars": false, "selWinScreenshots": true, "tabsCheck": true, "tabsFix": "notify", "markWindow": false, "markWindowPreface": "[Sidebery] ", "ctxMenuNative": false, "autoHideCtxMenu": "none", "ctxMenuRenderInact": true, "ctxMenuIgnoreContainers": "", "navBarLayout": "horizontal", "navBarInline": false, "hideAddBtn": false, "hideSettingsBtn": false, "navBtnCount": true, "hideEmptyPanels": true, "navActTabsPanelLeftClickAction": "none", "navActBookmarksPanelLeftClickAction": "none", "navMidClickAction": "none", "navSwitchPanelsWheel": true, "groupLayout": "grid", "skipEmptyPanels": false, "dndTabAct": true, "dndTabActDelay": 750, "dndTabActMod": "none", "dndExp": "pointer", "dndExpDelay": 0, "dndExpMod": "none", "stateStorage": "session", "warnOnMultiTabClose": "collapsed", "activateOnMouseUp": true, "activateLastTabOnPanelSwitching": true, "showTabRmBtn": true, "showTabCtx": true, "hideInact": false, "activateAfterClosing": "next", "activateAfterClosingPrevRule": "visible", "activateAfterClosingNextRule": "tree", "activateAfterClosingGlobal": false, "activateAfterClosingNoFolded": true, "activateAfterClosingNoDiscarded": true, "shiftSelAct": true, "askNewBookmarkPlace": false, "tabsRmUndoNote": true, "nativeHighlight": false, "tabsUnreadMark": false, "tabsReloadLimit": 5, "tabsReloadLimitNotif": true, "tabsPanelSwitchActMove": true, "moveNewTabPin": "start", "moveNewTabParent": "last_child", "moveNewTabParentActPanel": false, "moveNewTab": "end", "pinnedTabsPosition": "panel", "pinnedTabsList": false, "pinnedAutoGroup": false, "tabsTree": true, "groupOnOpen": true, "tabsTreeLimit": "none", "hideFoldedTabs": false, "autoFoldTabs": false, "autoFoldTabsExcept": "none", "autoExpandTabs": false, "rmChildTabs": "none", "tabsChildCount": true, "tabsLvlDots": false, "discardFolded": false, "discardFoldedDelay": 0, "discardFoldedDelayUnit": "sec", "tabsTreeBookmarks": true, "treeRmOutdent": "branch", "bookmarksPanel": true, "warnOnMultiBookmarkDelete": "collapsed", "openBookmarkNewTab": false, "midClickBookmark": "open_new_tab", "actMidClickTab": false, "autoCloseBookmarks": false, "autoRemoveOther": false, "highlightOpenBookmarks": false, "activateOpenBookmarkTab": false, "showBookmarkLen": false, "bookmarksRmUndoNote": true, "fontSize": "s", "bgNoise": true, "animations": true, "animationSpeed": "fast", "theme": "default", "style": "auto", "sidebarCSS": false, "groupCSS": false, "snapNotify": true, "snapExcludePrivate": false, "snapInterval": 0, "snapIntervalUnit": "min", "snapLimit": 0, "snapLimitUnit": "snap", "hScrollThroughPanels": false, "scrollThroughTabs": "none", "scrollThroughVisibleTabs": false, "scrollThroughTabsSkipDiscarded": false, "scrollThroughTabsExceptOverflow": true, "scrollThroughTabsCyclic": false, "tabDoubleClick": "none", "tabLongLeftClick": "none", "tabLongRightClick": "none", "tabsPanelLeftClickAction": "none", "tabsPanelDoubleClickAction": "tab", "tabsPanelRightClickAction": "menu", "tabsPanelMiddleClickAction": "tab", "syncName": "", "syncSaveSettings": false, "syncSaveCtxMenu": false, "syncSaveStyles": false, "syncAutoApply": false }, "permissions": { "allUrls": true, "tabHide": false, "actualAllUrls": true, "actualTabHide": false }, "storage": { "size": "114.6 kb", "props": { "containers_v4": "1.2 kb", "cssVars": "1.6 kb", "favAutoCleanTime": "10 b", "favUrls": "1.9 kb", "favicons": "104.3 kb", "panelIndex": "1 b", "panels_v4": "446 b", "prevTabsData_v4": "9 b", "profileID": "14 b", "settings": "2.8 kb", "tabsData_v4": "1.9 kb" } }, "panels": [ { "type": "bookmarks", "id": "bookmarks", "cookieStoreId": "bookmarks", "name": 9, "icon": "...", "bookmarks": true, "lockedPanel": false, "skipOnSwitching": false }, { "type": "default", "id": "firefox-default", "name": 7, "icon": "...", "cookieStoreId": "firefox-default", "lockedTabs": false, "lockedPanel": false, "skipOnSwitching": false, "noEmpty": false, "newTabCtx": "none", "dropTabCtx": "none", "moveTabCtx": "none", "moveTabCtxNoChild": true } ], "containers": [ { "id": "firefox-container-1", "name": 8, "icon": "...", "color": "...", "proxified": false, "proxy": null, "includeHostsActive": false, "includeHosts": "", "excludeHostsActive": false, "excludeHosts": "", "userAgentActive": false, "userAgent": "" }, { "id": "firefox-container-2", "name": 4, "icon": "...", "color": "...", "proxified": false, "proxy": null, "includeHostsActive": false, "includeHosts": "", "excludeHostsActive": false, "excludeHosts": "", "userAgentActive": false, "userAgent": "" }, { "id": "firefox-container-3", "name": 7, "icon": "...", "color": "...", "proxified": false, "proxy": null, "includeHostsActive": false, "includeHosts": "", "excludeHostsActive": false, "excludeHosts": "", "userAgentActive": false, "userAgent": "" }, { "id": "firefox-container-4", "name": 8, "icon": "...", "color": "...", "proxified": false, "proxy": null, "includeHostsActive": false, "includeHosts": "", "excludeHostsActive": false, "excludeHosts": "", "userAgentActive": false, "userAgent": "" }, { "id": "firefox-container-6", "name": 8, "icon": "...", "color": "...", "proxified": false, "proxy": null, "includeHostsActive": false, "includeHosts": "", "excludeHostsActive": false, "excludeHosts": "", "userAgentActive": false, "userAgent": "" } ], "cssVars": { "bg": "#151515" }, "windows": [ { "state": "normal", "incognito": false, "tabsCount": 1 }, { "state": "fullscreen", "incognito": false, "tabsCount": 17 }, { "state": "normal", "incognito": false, "tabsCount": 3 } ], "bookmarks": { "bookmarksCount": 96, "foldersCount": 11, "separatorsCount": 1, "maxDepth": 3 } }

d9i avatar Jul 29 '22 04:07 d9i

Thanks for the report. You're right, I should use cmd instead of ctrl in macOS.

mbnuqw avatar Aug 15 '22 18:08 mbnuqw

To add to this: this means that users cannot perform a right-click when using the trackpad (because that's ctrl-click on macOS). Instead of opening the right-click menu to interact with sidebery tabs, it selects a tab.

What works though:

  • using a mouse with dedicated right-click.
  • issuing a "secondary click" on the trackpad (click with index and middle finger).

SuperFluffy avatar Sep 30 '23 13:09 SuperFluffy