sidebery icon indicating copy to clipboard operation
sidebery copied to clipboard

Published 20 hours ago • verified publisher icon mbnuqw

[v5] 1st Child not able to become new parent

Open megamorphg opened this issue 2 years ago • 3 comments

Description

After opening a bunch of child tabs I sometimes need to make the 1st child a parent. In v4 this used to be as simple as pressing the keyboard shortcut to outdent. But in v5, outdenting 1st child doesn't work as we can see from this demo of outdenting+indenting parent, 1st child, and 2nd child: 2022-06-18-2230-58

The working alternative to this keyboard shortcut is to click and drag the 1st child tab out of the parent and then drag the other children into it.

This may be related to modifying how moving tabs up or down work as this "bug" : #669

megamorphg avatar Jun 19 '22 05:06 megamorphg

This behavior was introduced intentionally because when you outdent the first tab and then indent it back you also indent the whole new branch and get a different tree layout. But your use case is actually useful, now I think that it would be better to allow user to both create new branches with outdent and flatten the active branch with indent. I'll experiment with this...

mbnuqw avatar Jun 30 '22 17:06 mbnuqw

@mbnuqw

allow user to both create new branches with outdent and flatten the active branch with indent

Can we just let the active branch stay as is, letting it become the new parent? This is the way it worked in v4.

Sometimes there is a logical nesting under the branch that user would not want to reset. Maybe some people do not nest tabs and they would actually like to do that but sometimes I outdent accidentally and it screws up the tree I spent a while organizing and I have to go to a backup and restore..

I can imagine the use case for flattening the tree which is when the nesting is meaningless because of lots of browsing. But it should not be a default. Maybe we can have a separate keybinding or action for that?

Also is this related to #669 where the tree gets flattened when a tab is moved out of its tree?

megamorphg avatar Jul 01 '22 13:07 megamorphg

Maybe we can have a separate keybinding or action for that?

Yes, that's probably the way I'll do that.

Also is this related to https://github.com/mbnuqw/sidebery/issues/669 where the tree gets flattened when a tab is moved out of its tree?

No, it was a bug.

mbnuqw avatar Jul 11 '22 20:07 mbnuqw