sidebery
sidebery copied to clipboard
Loading unloaded tabs on session restore
Steps to reproduce
- Open Firefox after a crash or quit
- Opt to restore the last session (from the session restore prompt page or from History menu)
Actual behavior
When the restore last session option is selected, firefox loads tabs correctly for a second, and then all previously unloaded sessions are loaded simultaneously. browser.sessionstore.restore_tabs_lazily is set to true. If I disable Sidebery before selecting restore, it works as it should. Enabling Sidebery after the session is restored doesn't cause any further issues until the browser is restarted again. I believe this started only recently, possibly after a recent update. I remember Sidebery updating recently. I haven't added any new extensions before or after this issue started.
Expected behavior
When we opt to restore session, all the previously unloaded tabs are left unloaded when the browser.sessionstore.restore_tabs_lazily flag is set. This was the behaviour previously.
System
Windows 11
Firefox version
124.0.2 (64-bit)
Sidebery version
5.2.0.7
Logs
[bg] Init start chunk-E463RSEI.js:2:7892
[sidebar] Init start chunk-E463RSEI.js:2:7892
[sidebar:1] Sidebar.loadPanels chunk-E463RSEI.js:2:7892
[sidebar] Init start 8 chunk-E463RSEI.js:2:7892
[sidebar:1] Sidebar.loadPanels: Done: 28983ms chunk-E463RSEI.js:2:7892
[sidebar:1] Tabs.load chunk-E463RSEI.js:2:7892
[sidebar:1] Tabs.restoreTabsState chunk-E463RSEI.js:2:7892
[bg] Init end: 39903ms chunk-E463RSEI.js:2:7892
[bg] IPC.onConnected sidebar 1 chunk-E463RSEI.js:2:7892
[sidebar:85] Sidebar.loadPanels chunk-E463RSEI.js:2:7892
[sidebar:73] Sidebar.loadPanels chunk-E463RSEI.js:2:7892
[sidebar:81] Sidebar.loadPanels chunk-E463RSEI.js:2:7892
[sidebar:77] Sidebar.loadPanels chunk-E463RSEI.js:2:7892
[sidebar:83] Sidebar.loadPanels chunk-E463RSEI.js:2:7892
[sidebar:75] Sidebar.loadPanels chunk-E463RSEI.js:2:7892
[sidebar:79] Sidebar.loadPanels chunk-E463RSEI.js:2:7892
[sidebar:71] Sidebar.loadPanels chunk-E463RSEI.js:2:7892
[bg] Windows.isWindowTabsLocked 1 chunk-E463RSEI.js:2:7892
[sidebar:85] Sidebar.loadPanels: Done: 2765ms chunk-E463RSEI.js:2:7892
[sidebar:85] Tabs.load chunk-E463RSEI.js:2:7892
[sidebar:85] Tabs.restoreTabsState chunk-E463RSEI.js:2:7892
[sidebar:73] Sidebar.loadPanels: Done: 2762ms chunk-E463RSEI.js:2:7892
[sidebar:73] Tabs.load chunk-E463RSEI.js:2:7892
[sidebar:73] Tabs.restoreTabsState chunk-E463RSEI.js:2:7892
[sidebar:81] Sidebar.loadPanels: Done: 2841ms chunk-E463RSEI.js:2:7892
[sidebar:81] Tabs.load chunk-E463RSEI.js:2:7892
[sidebar:81] Tabs.restoreTabsState chunk-E463RSEI.js:2:7892
[sidebar:77] Sidebar.loadPanels: Done: 2826ms chunk-E463RSEI.js:2:7892
[sidebar:77] Tabs.load chunk-E463RSEI.js:2:7892
[sidebar:77] Tabs.restoreTabsState chunk-E463RSEI.js:2:7892
[sidebar:83] Sidebar.loadPanels: Done: 2814ms chunk-E463RSEI.js:2:7892
[sidebar:83] Tabs.load chunk-E463RSEI.js:2:7892
[sidebar:83] Tabs.restoreTabsState chunk-E463RSEI.js:2:7892
[sidebar:75] Sidebar.loadPanels: Done: 2796ms chunk-E463RSEI.js:2:7892
[sidebar:75] Tabs.load chunk-E463RSEI.js:2:7892
[sidebar:75] Tabs.restoreTabsState chunk-E463RSEI.js:2:7892
[sidebar:79] Sidebar.loadPanels: Done: 2784ms chunk-E463RSEI.js:2:7892
[sidebar:79] Tabs.load chunk-E463RSEI.js:2:7892
[sidebar:79] Tabs.restoreTabsState chunk-E463RSEI.js:2:7892
[sidebar:71] Sidebar.loadPanels: Done: 2756ms chunk-E463RSEI.js:2:7892
[sidebar:71] Tabs.load chunk-E463RSEI.js:2:7892
[sidebar:71] Tabs.restoreTabsState chunk-E463RSEI.js:2:7892
[sidebar:1] Tabs.restoreTabsFromCache chunk-E463RSEI.js:2:7892
[sidebar:1] Tabs.restoreTabsState: Done: 11642ms chunk-E463RSEI.js:2:7892
[sidebar:1] Tabs: Deferred event handlers: 2 chunk-E463RSEI.js:2:7978
[sidebar:1] Tabs.load: Done: 11771ms chunk-E463RSEI.js:2:7892
[sidebar:1] Init end: 51238ms chunk-E463RSEI.js:2:7892
[bg] IPC.onConnected sidebar 85 chunk-E463RSEI.js:2:7892
[bg] IPC.onConnected sidebar 73 chunk-E463RSEI.js:2:7892
[bg] IPC.onConnected sidebar 81 chunk-E463RSEI.js:2:7892
[bg] IPC.onConnected sidebar 77 chunk-E463RSEI.js:2:7892
[bg] IPC.onConnected sidebar 83 chunk-E463RSEI.js:2:7892
[bg] IPC.onConnected sidebar 75 chunk-E463RSEI.js:2:7892
[bg] IPC.onConnected sidebar 79 chunk-E463RSEI.js:2:7892
[bg] IPC.onConnected sidebar 71 chunk-E463RSEI.js:2:7892
[bg] Windows.isWindowTabsLocked 85 chunk-E463RSEI.js:2:7892
[bg] Windows.isWindowTabsLocked 73 chunk-E463RSEI.js:2:7892
[bg] Windows.isWindowTabsLocked 81 chunk-E463RSEI.js:2:7892
[bg] Windows.isWindowTabsLocked 77 chunk-E463RSEI.js:2:7892
[bg] Windows.isWindowTabsLocked 83 chunk-E463RSEI.js:2:7892
[bg] Windows.isWindowTabsLocked 75 chunk-E463RSEI.js:2:7892
[bg] Windows.isWindowTabsLocked 79 chunk-E463RSEI.js:2:7892
[bg] Windows.isWindowTabsLocked 71 chunk-E463RSEI.js:2:7892
[sidebar:85] Tabs.restoreTabsFromCache chunk-E463RSEI.js:2:7892
[sidebar:85] Tabs.restoreTabsState: Done: 2038ms chunk-E463RSEI.js:2:7892
[sidebar:85] Tabs.load: Done: 2166ms chunk-E463RSEI.js:2:7892
[sidebar:85] Init end: 42026ms chunk-E463RSEI.js:2:7892
[sidebar:73] Tabs.restoreTabsFromCache chunk-E463RSEI.js:2:7892
[sidebar:73] Tabs.restoreTabsState: Done: 2178ms chunk-E463RSEI.js:2:7892
[sidebar:73] Tabs: Deferred event handlers: 9 chunk-E463RSEI.js:2:7978
[sidebar:73] Tabs.load: Done: 2301ms chunk-E463RSEI.js:2:7892
[sidebar:73] Init end: 42039ms chunk-E463RSEI.js:2:7892
[sidebar:81] Tabs.restoreTabsFromCache chunk-E463RSEI.js:2:7892
[sidebar:81] Tabs.restoreTabsState: Done: 2074ms chunk-E463RSEI.js:2:7892
[sidebar:81] Tabs: Deferred event handlers: 1 chunk-E463RSEI.js:2:7978
[sidebar:81] Tabs.load: Done: 2259ms chunk-E463RSEI.js:2:7892
[sidebar:81] Init end: 39792ms chunk-E463RSEI.js:2:7892
[sidebar:77] Tabs.restoreTabsFromCache chunk-E463RSEI.js:2:7892
[sidebar:77] Tabs.restoreTabsState: Done: 2247ms chunk-E463RSEI.js:2:7892
[sidebar:77] Tabs.load: Done: 2285ms chunk-E463RSEI.js:2:7892
[sidebar:77] Init end: 39492ms chunk-E463RSEI.js:2:7892
[sidebar:83] Tabs.restoreTabsFromCache chunk-E463RSEI.js:2:7892
[sidebar:83] Tabs.restoreTabsState: Done: 2277ms chunk-E463RSEI.js:2:7892
[sidebar:83] Tabs.load: Done: 2386ms chunk-E463RSEI.js:2:7892
[sidebar:83] Init end: 39545ms chunk-E463RSEI.js:2:7892
[sidebar:75] Tabs.restoreTabsFromCache chunk-E463RSEI.js:2:7892
[sidebar:75] Tabs.restoreTabsState: Done: 2377ms chunk-E463RSEI.js:2:7892
[sidebar:75] Tabs.load: Done: 2474ms chunk-E463RSEI.js:2:7892
[sidebar:75] Init end: 39606ms chunk-E463RSEI.js:2:7892
[sidebar:79] Tabs.restoreTabsFromCache chunk-E463RSEI.js:2:7892
[sidebar:79] Tabs.restoreTabsState: Done: 2471ms chunk-E463RSEI.js:2:7892
[sidebar:79] Tabs.load: Done: 2547ms chunk-E463RSEI.js:2:7892
[sidebar:79] Init end: 39623ms chunk-E463RSEI.js:2:7892
[sidebar:71] Tabs.restoreTabsFromCache chunk-E463RSEI.js:2:7892
[sidebar:71] Tabs.restoreTabsState: Done: 2538ms chunk-E463RSEI.js:2:7892
[sidebar:71] Tabs.load: Done: 2635ms chunk-E463RSEI.js:2:7892
[sidebar:71] Init end: 39678ms chunk-E463RSEI.js:2:7892
[sidebar:1] IPC.request: No confirmation: bg cacheTabsData chunk-E463RSEI.js:2:7978
Uncaught (in promise) IPC.request: No port
[sidebar:83] IPC.request: No confirmation: bg cacheTabsData chunk-E463RSEI.js:2:7978
Uncaught (in promise) IPC.request: No port
[sidebar:85] IPC.request: No confirmation: bg cacheTabsData chunk-E463RSEI.js:2:7978
Uncaught (in promise) IPC.request: No port
[sidebar:81] IPC.request: No confirmation: bg cacheTabsData chunk-E463RSEI.js:2:7978
[sidebar:1] IPC.request: Target port has an error:
Object { message: "No confirmation" }
chunk-E463RSEI.js:3:25
[sidebar:1] IPC.request: Cannot find appropriate port, trying to reconnect... chunk-E463RSEI.js:2:7978
Uncaught (in promise) IPC.request: No port
[sidebar:1] IPC.connectTo: No confirmation: bg chunk-E463RSEI.js:2:7978
[sidebar:1] IPC.request: No confirmation: bg cacheTabsData chunk-E463RSEI.js:2:7978
Uncaught (in promise) IPC.request: No port
[bg] IPC.onDisconnected sidebar 1 chunk-E463RSEI.js:2:7892
[bg] IPC.onConnected sidebar 1 chunk-E463RSEI.js:2:7892
[sidebar:81] IPC.request: Target port has an error:
Object { message: "No confirmation" }
chunk-E463RSEI.js:3:25
[sidebar:81] IPC.request: Cannot find appropriate port, trying to reconnect... chunk-E463RSEI.js:2:7978
[sidebar:1] IPC.request: Target port has an error:
Object { message: "No confirmation" }
chunk-E463RSEI.js:3:25
[sidebar:1] IPC.request: Cannot find appropriate port, trying to reconnect... chunk-E463RSEI.js:2:7978
[bg] IPC.onDisconnected sidebar 81 chunk-E463RSEI.js:2:7892
[bg] IPC.onConnected sidebar 81 chunk-E463RSEI.js:2:7892
[bg] IPC.onDisconnected sidebar 1 chunk-E463RSEI.js:2:7892
[bg] IPC.onConnected sidebar 1 chunk-E463RSEI.js:2:7892
[sidebar:81] IPC.connectTo: No confirmation: bg chunk-E463RSEI.js:2:7978
[sidebar:81] IPC.request: No confirmation: bg cacheTabsData chunk-E463RSEI.js:2:7978
Uncaught (in promise) IPC.request: No port
[sidebar:1] IPC.connectTo: No confirmation: bg chunk-E463RSEI.js:2:7978
[sidebar:1] IPC.request: No confirmation: bg cacheTabsData 2 chunk-E463RSEI.js:2:7978
Uncaught (in promise) IPC.request: No port 2
[bg] IPC.request: No confirmation: sidebar getGroupInfo chunk-E463RSEI.js:2:7978
[bg] Tabs: Cannot get tabs info for group page
IPC.request: No port chunk-E463RSEI.js:3:25
[sidebar:1] IPC.request: No confirmation: bg cacheTabsData chunk-E463RSEI.js:2:7978
Uncaught (in promise) IPC.request: No port
I have been noticing the same behaviour on different machines. All the tabs start to initialise and load up on browser startup, causing slowdown.
The browser tabs in all tab panels load up, not just the main/first panel.
Happened in the last week or so.
Version 5.2.0 Last Updated 12 March 2024