sidebery
sidebery copied to clipboard
mbnuqw
Closing tabs is now inaccurate since recent updates
Steps to reproduce
- Open Firefox in new profile
- Install Sidebery
- Try to close tabs
Expected behavior
Using middle-mouse button click the tabs closed should be the ones under the mouse cursor.
Actual behavior
Tabs not under mouse cursor are now being closed.
Debug info
Addon data
{
"addonVersion": "5.0.0",
"firefoxVersion": "118.0.2",
"settings": {
"nativeScrollbars": false,
"nativeScrollbarsThin": true,
"nativeScrollbarsLeft": false,
"selWinScreenshots": false,
"updateSidebarTitle": true,
"markWindow": false,
"markWindowPreface": "[Sidebery] ",
"ctxMenuNative": false,
"ctxMenuRenderInact": true,
"ctxMenuRenderIcons": true,
"ctxMenuIgnoreContainers": "",
"navBarLayout": "horizontal",
"navBarInline": true,
"navBarSide": "left",
"hideAddBtn": false,
"hideSettingsBtn": false,
"navBtnCount": true,
"hideEmptyPanels": true,
"hideDiscardedTabPanels": false,
"navActTabsPanelLeftClickAction": "none",
"navActBookmarksPanelLeftClickAction": "none",
"navTabsPanelMidClickAction": "discard",
"navBookmarksPanelMidClickAction": "none",
"navSwitchPanelsWheel": true,
"subPanelRecentlyClosedBar": true,
"subPanelBookmarks": true,
"subPanelHistory": true,
"groupLayout": "grid",
"containersSortByName": false,
"skipEmptyPanels": false,
"dndTabAct": true,
"dndTabActDelay": 750,
"dndTabActMod": "none",
"dndExp": "pointer",
"dndExpDelay": 0,
"dndExpMod": "none",
"dndOutside": "win",
"dndActTabFromLink": true,
"dndActSearchTab": true,
"dndMoveTabs": false,
"dndMoveBookmarks": false,
"searchBarMode": "dynamic",
"searchPanelSwitch": "same_type",
"searchBookmarksShortcut": "",
"searchHistoryShortcut": "",
"warnOnMultiTabClose": "none",
"activateLastTabOnPanelSwitching": true,
"activateLastTabOnPanelSwitchingLoadedOnly": true,
"switchPanelAfterSwitchingTab": "always",
"tabRmBtn": "hover",
"activateAfterClosing": "next",
"activateAfterClosingStayInPanel": false,
"activateAfterClosingGlobal": false,
"activateAfterClosingNoFolded": true,
"activateAfterClosingNoDiscarded": true,
"askNewBookmarkPlace": false,
"tabsRmUndoNote": true,
"tabsUnreadMark": false,
"tabsUpdateMark": "all",
"tabsUpdateMarkFirst": true,
"tabsReloadLimit": 5,
"tabsReloadLimitNotif": true,
"showNewTabBtns": true,
"newTabBarPosition": "after_tabs",
"tabsPanelSwitchActMove": true,
"tabsPanelSwitchActMoveAuto": true,
"tabsUrlInTooltip": "full",
"newTabCtxReopen": false,
"tabWarmupOnHover": true,
"tabSwitchDelay": 0,
"moveNewTabPin": "start",
"moveNewTabParent": "last_child",
"moveNewTabParentActPanel": false,
"moveNewTab": "end",
"moveNewTabActivePin": "start",
"pinnedTabsPosition": "panel",
"pinnedTabsList": false,
"pinnedAutoGroup": false,
"pinnedNoUnload": false,
"tabsTree": true,
"groupOnOpen": true,
"tabsTreeLimit": "none",
"autoFoldTabs": false,
"autoFoldTabsExcept": "none",
"autoExpandTabs": false,
"autoExpandTabsOnNew": false,
"rmChildTabs": "folded",
"tabsLvlDots": false,
"discardFolded": false,
"discardFoldedDelay": 0,
"discardFoldedDelayUnit": "sec",
"tabsTreeBookmarks": true,
"treeRmOutdent": "first_child",
"ignoreFoldedParent": false,
"colorizeTabs": false,
"colorizeTabsSrc": "domain",
"colorizeTabsBranches": false,
"colorizeTabsBranchesSrc": "url",
"inheritCustomColor": true,
"hideInact": false,
"hideFoldedTabs": false,
"hideFoldedParent": "none",
"nativeHighlight": false,
"warnOnMultiBookmarkDelete": "collapsed",
"autoCloseBookmarks": false,
"autoRemoveOther": false,
"highlightOpenBookmarks": false,
"activateOpenBookmarkTab": false,
"showBookmarkLen": false,
"bookmarksRmUndoNote": true,
"loadBookmarksOnDemand": true,
"pinOpenedBookmarksFolder": true,
"oldBookmarksAfterSave": "ask",
"loadHistoryOnDemand": true,
"fontSize": "m",
"animations": true,
"animationSpeed": "fast",
"theme": "proton",
"density": "default",
"colorScheme": "ff",
"sidebarCSS": false,
"groupCSS": false,
"snapNotify": true,
"snapExcludePrivate": false,
"snapInterval": 0,
"snapIntervalUnit": "min",
"snapLimit": 0,
"snapLimitUnit": "snap",
"snapAutoExport": false,
"snapAutoExportType": "json",
"snapAutoExportPath": "Sidebery/snapshot-%Y.%M.%D-%h.%m.%s",
"snapMdFullTree": false,
"hScrollAction": "none",
"navSwitchPanelsDelay": 128,
"scrollThroughTabs": "global",
"scrollThroughVisibleTabs": true,
"scrollThroughTabsSkipDiscarded": true,
"scrollThroughTabsExceptOverflow": true,
"scrollThroughTabsCyclic": false,
"scrollThroughTabsScrollArea": 0,
"autoMenuMultiSel": true,
"multipleMiddleClose": false,
"longClickDelay": 500,
"wheelThreshold": false,
"wheelThresholdX": 10,
"wheelThresholdY": 60,
"tabDoubleClick": "none",
"tabsSecondClickActPrev": true,
"tabsSecondClickActPrevPanelOnly": false,
"shiftSelAct": true,
"activateOnMouseUp": true,
"tabLongLeftClick": "new_child",
"tabLongRightClick": "duplicate",
"tabMiddleClick": "close",
"tabMiddleClickCtrl": "discard",
"tabMiddleClickShift": "duplicate",
"tabCloseMiddleClick": "close",
"tabsPanelLeftClickAction": "none",
"tabsPanelDoubleClickAction": "tab",
"tabsPanelRightClickAction": "menu",
"tabsPanelMiddleClickAction": "tab",
"newTabMiddleClickAction": "new_child",
"bookmarksLeftClickAction": "open_in_act",
"bookmarksLeftClickActivate": false,
"bookmarksLeftClickPos": "default",
"bookmarksMidClickAction": "open_in_new",
"bookmarksMidClickActivate": false,
"bookmarksMidClickRemove": false,
"bookmarksMidClickPos": "default",
"historyLeftClickAction": "open_in_act",
"historyLeftClickActivate": false,
"historyLeftClickPos": "default",
"historyMidClickAction": "open_in_new",
"historyMidClickActivate": false,
"historyMidClickPos": "default",
"syncName": "",
"syncSaveSettings": false,
"syncSaveCtxMenu": false,
"syncSaveStyles": false,
"syncSaveKeybindings": false,
"selectActiveTabFirst": true
},
"permissions": {
"allUrls": false,
"webRequest": false,
"webRequestBlocking": false,
"proxy": false,
"tabHide": false,
"clipboardWrite": true,
"history": true,
"bookmarks": true,
"downloads": false
},
"storage": {
"size": "514 kb",
"props": {
"containers": "1.07 kb",
"expandedBookmarkFolders": "2 b",
"favDomains": "26.8 kb",
"favHashes": "6.56 kb",
"favicons_01": "305 kb",
"favicons_02": "156 kb",
"favicons_03": "2 b",
"favicons_04": "2 b",
"favicons_05": "2 b",
"profileID": "14 b",
"settings": "4.82 kb",
"sidebar": "386 b",
"tabsDataCache": "13.1 kb",
"ver": "7 b"
}
},
"sidebar": {
"panels": {
"2uXHWgdO-qj9": {
"type": 2,
"id": "2uXHWgdO-qj9",
"name": "len: 4",
"color": "toolbar",
"iconSVG": "icon_tabs",
"iconIMGSrc": "",
"iconIMG": "",
"lockedPanel": false,
"skipOnSwitching": false,
"noEmpty": false,
"newTabCtx": "none",
"dropTabCtx": "none",
"moveRules": [],
"moveExcludedTo": -1,
"bookmarksFolderId": -1,
"newTabBtns": [],
"srcPanelConfig": null
}
},
"nav": [
"2uXHWgdO-qj9",
"add_tp",
"sp-0",
"settings"
]
},
"containers": [
{
"id": "firefox-container-1",
"cookieStoreId": "firefox-container-1",
"name": "8",
"icon": "...",
"color": "blue",
"colorCode": "#37adff",
"proxified": false,
"proxy": null,
"reopenRulesActive": false,
"reopenRules": [],
"userAgentActive": false,
"userAgent": ""
},
{
"id": "firefox-container-2",
"cookieStoreId": "firefox-container-2",
"name": "4",
"icon": "...",
"color": "orange",
"colorCode": "#37adff",
"proxified": false,
"proxy": null,
"reopenRulesActive": false,
"reopenRules": [],
"userAgentActive": false,
"userAgent": ""
},
{
"id": "firefox-container-3",
"cookieStoreId": "firefox-container-3",
"name": "7",
"icon": "...",
"color": "green",
"colorCode": "#37adff",
"proxified": false,
"proxy": null,
"reopenRulesActive": false,
"reopenRules": [],
"userAgentActive": false,
"userAgent": ""
},
{
"id": "firefox-container-4",
"cookieStoreId": "firefox-container-4",
"name": "8",
"icon": "...",
"color": "pink",
"colorCode": "#37adff",
"proxified": false,
"proxy": null,
"reopenRulesActive": false,
"reopenRules": [],
"userAgentActive": false,
"userAgent": ""
}
],
"windows": [
{
"state": "maximized",
"incognito": false,
"tabsCount": 115
}
],
"bookmarks": {
"bookmarksCount": 123,
"foldersCount": 7,
"separatorsCount": 0,
"maxDepth": 2
}
}
I can't seem to reproduce it on demand. See the video below for one instance of it - this occurred when using middle-mouse click to close tabs.
Logs
To get logs:
- Open DevTools (open this url in new tab: about:devtools-toolbox?id=%7B3c078156-979c-498b-8990-85f7987dd929%7D&type=extension).
- Navigate to "console" tab.
- Click on the trash bin icon (at the top-left) to clear console.
- Then try to reproduce the issue.
- If messages appear, copy and paste them here inside this codeblock, replacing this text.
https://github.com/mbnuqw/sidebery/assets/12621257/9959c141-a7c0-4827-a0bb-5e2d1b45e407 / https://streamable.com/x3y81j
I'm sorry, I do not have a solution for you.
But I do use the middle-mouse button exclusively to close tabs. I use nothing else.
With having around 2000 tabs open constantly (in many groups spread across 7 panels), and opening and closing hundreds of tabs every day, I can honestly say I use "middle-click to close" an awful lot. But I have never seen that behavior. Sidebery always only closes the tab under the mouse cursor.
Maybe I'm asking something you have already tried, but have you tried disabling ALL other extensions and only Sidebery active, to see if that changes anything?
Or, even better, tried creating a fresh new profile in Firefox, to see if the problem persists? I have seen some pretty odd behavior in Firefox caused by a corrupt/badly functioning profiles. I don't know. Maybe it is worth trying?
I'm also experiencing the same problem even after disabling all of my other add-ons except for BitWarden and AdNauseum Attempting to close a tab closes the one above it.
Can confirm that the issue is really present for quite a while now. At first, I thought that I've just misclicked while closing tabs one-after-another with middle click. But recently I've discovered that the issue is present even when I close tab by left-clicking on its cross icon. The first click will close the tab under the cursor, but the second will close the tab above the one under the cursor. Too bad the bug is not 100% reproducible - right now I triggered it two or three times in a row and then all of a sudden it can't be triggered anymore.
i experience this on multiple devices on all these devices i have at least 100 tabs open.
Seeing this behavior occasionally here. I have a couple hundred tabs open and middle-clicking to close my tab will sometimes close other tabs as well without warning. Using the X to close the tab instead seems to work properly.
