svmlight-loader icon indicating copy to clipboard operation
svmlight-loader copied to clipboard

Missing 'query_id' -- breaks API compatibility with sklearn

Open h4ste opened this issue 11 years ago • 1 comments

Source: http://scikit-learn.org/stable/modules/generated/sklearn.datasets.load_svmlight_file.html

sklearn.datasets.load_svmlight_file(f, n_features=None, dtype=<type 'numpy.float64'>, multilabel=False, zero_based='auto', query_id=False)

This implementation doesn't support the query_id argument, which breaks drop-in API compatibility.

h4ste avatar Jun 19 '14 21:06 h4ste

Indeed, adding support for query_id would be nice. I just never had the need for it yet.

The loader in scikit-learn also supports reading from file objects, so this implementation will never be an exact drop-in replacement.

mblondel avatar Jun 20 '14 00:06 mblondel