acts-as-taggable-on Added ignore

Added ignore_deleted option

Open rolandoalvarado opened this issue 5 years ago • 4 comments

Jun 04 '19 10:06 rolandoalvarado

do you think the test will work if I remove the gem and require directive? @gzzengwei

Or maybe you have other idea.

Jun 06 '19 06:06 rolandoalvarado

There are 6 failed CI Build which will be fix by this MR: https://github.com/mbleigh/acts-as-taggable-on/pull/951 courtesy of @damianlegawiec

Jun 06 '19 06:06 rolandoalvarado

@gzzengwei in our cases we don't have specific version but as stated in Contributing.md docs test needs to be pass to be merge.

Jun 06 '19 06:06 rolandoalvarado

@damianlegawiec I have pick few of your changes to make CI green. I will just rebase with master once your PR is merged. Thanks in advance.

Jun 06 '19 06:06 rolandoalvarado