pyang icon indicating copy to clipboard operation
pyang copied to clipboard

Identifier incorrect in SID file for nodes using an imported type

Open christian-herber opened this issue 3 years ago • 4 comments

@lemikev This ticket is likely related to https://github.com/mbj4668/pyang/issues/730 I found another corner case, where things are not precise in the generated SID files. When using an imported type, the identifier includes the namespace of the included module.

Example:

"identifier": "/ieee802-dot1cb-stream-identification:stream-identity-list/ieee802-dot1cb-stream-identification-types:handle",

the handle leaf should not be prefixed with the *-types namespace.

christian-herber avatar May 26 '21 14:05 christian-herber

@christian-herber

Effectively, this need to be fixed. If you have the complete set of yang files for this example, pls send them at [email protected].

lemikev avatar May 26 '21 17:05 lemikev

the example is based on these modules: https://github.com/YangModels/yang/blob/master/standard/ieee/draft/802.1/CBcv/ieee802-dot1cb-stream-identification.yang https://github.com/YangModels/yang/blob/master/standard/ieee/draft/802.1/CBcv/ieee802-dot1cb-stream-identification-types.yang

christian-herber avatar May 27 '21 09:05 christian-herber

i think this is fixed in the latest release of pyang. If you confirm, I propose to close this ticket

christian-herber avatar Jun 30 '21 11:06 christian-herber

I not sure this is fixed yet. Let me check this issue next week. I'll come back to you with a definitive answer.

Regards, Michel

From: christian-herber @.> Sent: 30 juin 2021 07:06 To: mbj4668/pyang @.> Cc: Michel Veillette @.>; Mention @.> Subject: Re: [mbj4668/pyang] Identifier incorrect in SID file for nodes using an imported type (#746)

External Email: Please use caution when opening links and attachments / Courriel externe: Soyez prudent avec les liens et documents joints

i think this is fixed in the latest release of pyang. If you confirm, I propose to close this ticket

You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmbj4668%2Fpyang%2Fissues%2F746%23issuecomment-871307008&data=04%7C01%7CMichel.Veillette%40trilliant.com%7Ca363ead74bdc42ca871108d93bb7118a%7C4f6fbd130dfb415085c3d43260c04309%7C0%7C0%7C637606479752239261%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=Y2sMqyyIfFCviHL0HvndT9PwnO0s3mDw0ugfNptTOBM%3D&reserved=0, or unsubscribehttps://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FADZVLN4MBOX5APCHP6UE6BDTVL3CFANCNFSM45SGZZFA&data=04%7C01%7CMichel.Veillette%40trilliant.com%7Ca363ead74bdc42ca871108d93bb7118a%7C4f6fbd130dfb415085c3d43260c04309%7C0%7C0%7C637606479752239261%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=PMje1Fxzhx8iUPaw3U440WRWg85F4FjXKLb%2FMMaZOWY%3D&reserved=0.

lemikev avatar Jun 30 '21 13:06 lemikev