Martin Bjorklund

Results 91 comments of Martin Bjorklund

Yes. I did some more fixes so that things like eunit works, but I think that you probably will do a better (correct) implementation anyway, so I think you can...

Ok, I pushed the other changes we did. In our project we have additional generated erl files (which we append to ERL_FILES), and it seems to work.

Sure, here's the relevant snippet of the Makefile. ``` ERLC_USE_SERVER = true export ERLC_USE_SERVER EUNIT_OPTS = verbose,{print_depth,9999},{report,{eunit_surefire,[{dir,"."}]}} include $(TOP_DIR)/mk/erlang.mk ebin/$(PROJECT).app:: $(wildcard $(PROJECT_ENV_FILE)) # there is no variable LOCAL_BUILD_DEPS in erlang.mk,...

Ok. +1 to the package changes as well!

This is the only place that I noticed this problem (specifically that the .d file was invalid) There might be other characters except "#" and " " that become problematic,...

That probably works for this particular case. But do see any issues with my solution?

My initial idea was to escape #, but I couldn't figure out how to do that. I agree about the adding of greps. An alternative could be to extend the...

@hyberdk please verify this fix on the modules you have.

See my comment in #729 as well. The XE models are "broken" in the sense that they don't follow the scoping rules for YANG 1. I just pushed another fix...

It seems this issue has been fixed in recent versions of pyang.