devtools icon indicating copy to clipboard operation
devtools copied to clipboard

Extract remaining rake task bodies

Open backus opened this issue 9 years ago • 7 comments

Continuing in-place refactoring of rake tasks.

backus avatar Nov 02 '15 05:11 backus

@mbj I changed class bodies to use config instead. This was a quick change and I've committed the changes as fixup! commits so you can see the changes by themselves. I haven't done the refactoring step yet but if you would like to do another pass on the extraction itself I've addressed your flag

backus avatar Nov 03 '15 08:11 backus

@backus I like the direction this is going. In case you do not have the time to finish it, I'll take this PR over.

mbj avatar Nov 04 '15 18:11 mbj

@mbj Go for it. I can still contribute some work on weekends. If you start paving out a general pattern for how you refactor the different tasks I can follow and apply that pattern for others

backus avatar Nov 04 '15 18:11 backus

@mbj Go for it. I can still contribute some work on weekends. If you start paving out a general pattern for how you refactor the different tasks I can follow and apply that pattern for others

I'll focus on one specific tool (mutant). Once we are happy with that one we can introduce the same thing for the others.

mbj avatar Nov 04 '15 18:11 mbj

I'll focus on one specific tool (mutant).

Great. Note https://github.com/mbj/devtools/commit/018a41321623a528c90d55eca22cc79f54387940 in that case. I had to change the task body a bit before adding tests because

namespace =
  if config.zombify
    Mutant.zombify
    Zombie::Mutant
  else
    Mutant
  end

isn't valid given the mutant public API anymore

backus avatar Nov 04 '15 18:11 backus

isn't valid given the mutant public API anymore

Yeah, I plan to go through the CLI API.

mbj avatar Nov 04 '15 18:11 mbj

I still do have a separate branch locally which captures Flay's reporting as a string instead of having it directly report to STDOUT. I'll try to pull that up as a separate feature branch later

backus avatar Nov 04 '15 18:11 backus