Markus Schirp

Results 267 comments of Markus Schirp

@marcandre This issue contains 2 classes: The splat node not dispatching mlhs correctly, that one is fixed. The other is the dstr issue I discuss in #196

@marcandre There is another class, and its interesting: `spec/char_cover/exception_else.rb` contains code like this: ``` begin else end ``` that when parsed with parser: ``` bundle exec ruby-parse -e 'begin; else;...

@camertron I'm tooooo busys to reply verbosely. Your approach is right, but. and that but requires a longer elaboration I cannot find the time for this and likely next week.

> A few files that generate errors with `unparser`, but have ok syntax according to `ruby -c`: I've to go with ok syntax according to `ruby-parser`. Nevertheless there are valid...

@marcandre All of them (past the earlier 2 you reported that where easy to fix) seem to be issues from the string / dstring madness. Most of them are triggered...

> It's not clear to me what the issue is, but I trust it should be possible to find an equivalent Ruby source code from the AST. Good luck There...

@marcandre I've investigated almost all of the errors by now and they are all "dstring mangling" I talked about earlier. I suspect it may be easier to change `parser` to...

@iliabylich I'm totally fine to use "consecutive" `str` nodes inside `dstr` as a hint for multi line / heredoc etc, even in the absence of interpolation. But we could potentially...

> I'm not sure if I understand the point of reducing AST for _some_ cases when users still need all cases. Could you explain it please? Simply managing the complexity...

@iliabylich You have have misunderstood unparsers propose: Its NOT meant to reproduce your concrete syntax. Its only meant to reproduce concrete syntax that when parsed again produces the same AST....