Michael Bien

Results 600 comments of Michael Bien

this did also repair the "pin tab" feature. I can now open multiple terminals, pin them and when NB is restarted it will restore them again -> great fix! ![image](https://github.com/user-attachments/assets/01805b0a-45ce-47fc-be0f-179225c560ad)

duplicate of https://github.com/apache/netbeans/issues/6671 can also happen during indexing: https://github.com/apache/netbeans/issues/4762 also see the question in https://github.com/apache/netbeans/issues/6671#issuecomment-1806606757

as mentioned on the other issue, the exception is intended for search/replace since the file must be correctly decodeable when replacing something in it. So if this is happening on...

I don't disagree, I just mean that there is another layer to that, NB controls _when_ the error should be thrown or not: ` decoder.onMalformedInput(CodingErrorAction.REPORT); ` it is meant to...

this might be a good place catch `CoderMalfunctionError`, but this is only for the `SingleLineStreamMatcher`, there are likely more places (indexing included) - thats why it would be good to...

@keosion thanks for the reproducer. Will check if this can be improved for NB 26.

I am not sure if its a good idea to split scaling into two stages handled by two dependencies. There are already enough edge cases with one scale factor (multi...

> It's the best idea that works for me in my current environment. works-for-me is a good starting point but the hard part is to make sure that it keeps...

@Achal1607 just a nitpick for future PRs: it is better to describe in the commit msg what the commit changed or why the changes were made. When looking through history...

@Achal1607 you can still change it if you want ;)