Michael Bien
Michael Bien
> By header, you mean the commits or the pull request? I will probably need to disable a certain Github option... the commits. `git log` of your branch i checked...
> I just noticed that time stamps on the commits were lost... I am trying to decide if they are important enough to fix... time stamps going to usually change...
> In regards to optimization, we could us a wrapper `CharSequence` to avoid creating 3 Strings when we check a method. That would require modifications to other methods as well....
> Is the "Do not merge" tag still applicable? I think so. - I would still like to check that this does not introduce a performance regression since it does...
> So, I tested this file with and without the 3 additional checks and didn't notice any difference (yes, I added methods). My attempt to profile the methods in question...
@neilcsmith-net @matthiasblaesing would we need a setting in the options for this or is it ok to have this always enabled?
i have to apologize to @SirIntellegence since I didn't actually know that the feature was already there, otherwise I would have mentioned it right away before reviewing.
wanted to suggest to add a test case for it but the code folding tests don't work anyway and probably haven't been run for a long time, so I suppose...
you mean you can't run it without building it first?
ok. So the title is wrong. It builds fine. If you press run without building first, it won't run. But if you build, it will run afterwards.