Michael Bien

Results 311 comments of Michael Bien

@WhiteHsu can you move this to a github discussion (or the mailing list)? Its better to talk there instead of using an issue for it.

@cazonda sure if you want. But this isn't really required to work on an issue.

@cazonda sorry, what I mean is that you can work on this issue without asking someone to assign it to you. Its good that you mentioned that you want to...

start with JDK 11 or select a unpack200 implementation when the warning dialog shows up. you can set the `netbeans_jdkhome` property in your etc/netbeans.conf to your JDK 11 folder.

can reproduce with NB 15. Haven't tested on master which has a newer javac from JDK 19 in it. ``` java.lang.AssertionError at com.sun.tools.javac.util.Assert.error(Assert.java:155) at com.sun.tools.javac.util.Assert.checkNonNull(Assert.java:62) at com.sun.tools.javac.comp.Modules.allModules(Modules.java:1216) at com.sun.tools.javac.model.JavacElements.getAllModuleElements(JavacElements.java:127) at...

I'll take a look if I can fix this.

> @mbien sorry, should have assigned myself. Just opening a PR now. do worries. I just started looking into it while walking through the stack backwards and the code looked...

I am wondering if the NB utilities like `ElementHandle` should/could check the phase (`compilationInfo.getPhase()`) so that they can throw better exceptions in future. But I lack the experience of all...

please provide a minimal reproducer.