knockout-deferred-updates icon indicating copy to clipboard operation
knockout-deferred-updates copied to clipboard

Merge knockout-deferred-updates into master

Open mpj opened this issue 12 years ago • 9 comments

Because it's awsum and the right thing to do.

mpj avatar Feb 04 '13 15:02 mpj

Yeah. I think it will be eventually.

mbest avatar Feb 04 '13 21:02 mbest

subscription slow down when ko.deferred enabled, comparison: http://jsperf.com/ko-computed-vs-subscription http://jsperf.com/ko-computed-vs-subscription-deferred

computed: 3x (cool!) but subscription: 0.5x

vamp avatar Mar 30 '13 21:03 vamp

subscription slow down when ko.deferred enabled

That's interesting, I'll take a look when I have some time.

mbest avatar Apr 01 '13 08:04 mbest

I've just made some updates to improve performance. The biggest functional change is that it now also eliminates duplicate updates for manual subscriptions.

mbest avatar Apr 03 '13 02:04 mbest

Here's your test using the new version: http://jsperf.com/ko-computed-vs-subscription-deferred/2

mbest avatar Apr 03 '13 02:04 mbest

Cool! Great work!

vamp avatar Apr 03 '13 09:04 vamp

:+1: for merging to knockout officially. It's a must for any projects of a non-trivial scale. Any news on this?

I've forked Knockout for my own customizations but knockout-deferred overwrites some of the code in Knockout (mainly the computed) thus interfering with those changes. I'd rather not have to fork knockout-deferred as well.

juuxstar avatar Aug 13 '14 00:08 juuxstar

I'll need to update this to support Knockout 3.2

mbest avatar Aug 13 '14 05:08 mbest

@juuxstar. I understand your point about changing both. I'm hoping this will join Knockout whenever we do 4.0.

mbest avatar Aug 13 '14 05:08 mbest