Marco Berzborn
Marco Berzborn
Indeed, we started using ABC only after the Filter classes were implemented. Feel free to introduce their use for the new LTISystem implementation.
> I made `Filter` an `ABC` but now the tests are failing because `Filter` can no longer be instantiated. I cannot think of a use case of instantiating a `Filter`...
I'm marking this as "implementation in progress" (given the last commit message contains WIP)
@sikersten are you available to re-review?
The anticipated overhead @f-brinkmann is referring to is that channel labels would need to be broadcast or adapted every time the shape of the signal changes. As mentioned, the same...
For plotting you can use the default matplotlib way of labeling things. No need to add extra parameters to the plot functions ;)
Thanks for making this initial push. I assume it's a good basis to have a more extensive discussion during one of the meetings. One important question comes to my mind...
closing in favor of #710
I've thought about adding such functionality a couple of times as well. So definitely in favor. Especially the abs, real, imag, and conj fucntions would be quite convenient to have.
Similar implementations exist for pf.Coordinates (see #602) There seem to be some inconsitencies across different classes/methods/functions, which we should take care of at the same time. Additional functions could be:...