feat: add charset parmater

Open fengkx opened this issue 6 years ago • 2 comments

Add charset parmater to test different encoding

Mar 26 '20 08:03 fengkx

Heroku demo for this branch: https://rss-test-charset.herokuapp.com/

Mar 26 '20 09:03 fengkx

Thank you very much for this change, @fengkx.

I have provided some comments I'd love for you to fix before I merge the branch.

The other very important thing is, if the user provides an encoding that is not supported, they get this error:

Error: Encoding not recognized: 'sdfsdf' (searched as: 'sdfsdf')

I think it would be better if you added a check using iconv.encodingExists(charset) and send an official 500 error message if the encoding is not supported.

Apr 23 '20 23:04 mbertolacci