Marnik Bercx

Results 301 comments of Marnik Bercx

@sphuber I agree that we _need_ to make sure the casing is consistent. Else _anywhere_ you check an input parameter or setting (not just in `PwParser`, but also _anywhere_ in...

Thanks @sphuber, you make some valid points. I agree that adapting the `serializer` would muddy the concept of what a serializer is supposed to do and potentially open a Pandora's...

@AndresOrtegaGuerrero this should do the job, but there is one thing I'm still considering. For provenance reasons, in case the structure has changed I still pass it as an input...

Thanks @bastonero! Unfortunately this doesn't make the decision easier. ^^ Can we see from the outputs if QE has been compiled with HDF5? I suppose we could do a full...

Interesting. I completely forgot about this, but I seem to have reimplemented a lot of this in one of my own packages: https://github.com/mbercx/vsc-workflows/blob/master/vscworkflows/tools/optics.py Which I actually used in the analysis...

Thanks @superstar54! What version of QE are you running here? Could you maybe also provide the corresponding output files (`aiida.out`, `data-file-schema.xml`) so I can set up a test for this?

> Are we only supporting v7.0 and up now @mbercx ? And is the location of this keyword consistent for all other versions > v7.0? Both good questions. Indeed, according...

> Here you have an example of dataschema using the latest (v7.2) QE version. Indeed, the output_parameters has incorrectly lda_plus_u_correction: False in my PwCalculation node. Thanks! > Shall we also...

Yeah, fair point, was also considering we should adapt the `BaseRestartWorkChain` and came back to see you had the same conclusion. ^^ ~~Let's keep this issue open until we fix...

Hmm, ok, thank for the explanation @sphuber! I'd say it's not urgent, so let's take some time to consider and write down the design.