passport-custom icon indicating copy to clipboard operation
passport-custom copied to clipboard

Strategy parameters does not match the standard

Open Tyki opened this issue 5 years ago • 1 comments

Hi,

It looks like the signature of the function Strategy does not respect the standard. For example : https://github.com/jaredhanson/passport-local/blob/master/lib/strategy.js

The first parameter is the options and the second one is the verify. When using passport.use, the definition should be

passport.use(options, new CustomStrategy(....))

Would you appreciate a PR on this and release a new major version of the passport-custom with this breaking-change ?

Tyki avatar Sep 26 '19 14:09 Tyki

Sure addd the PR

mbell8903 avatar Feb 11 '20 23:02 mbell8903