Malcolm Bechard comments

Results 71 comments of


                                            Malcolm Bechard

png_set_cHRM() fails when using ACEScg coordinates

Yep sorry, it's working well for me now.

png_set_cHRM() fails when using ACEScg coordinates

Amazing, thanks for your attention to this!

SECURITY: possible integer overflow with some cHRM chunk values

Yes, the ACEScg test I have still works with this patch instead of the other.

Add procedure for handling opaque struct members

This looks good to me

GLSLForceScalarLayout doesn't seem to work as CompileOptionEntry

Just got hit by this one. At the very least the documentation should be improved. The documentation implies that `forceGLSLScalarBufferLayout` is only used for GLSL shaders. In my case I'm...

Change to CMake install rule for the include directory?

Thanks, at the top level I include ``` #include #include #include #include ``` The complete list of missing headers due to chained includes is: Include/Common.h Include/PoolAlloc.h Include/Types.h Include/BaseTypes.h Include/arrays.h Include/SpirvInstrinsics.h...

Change to CMake install rule for the include directory?

Sure, I use classes exposed in iomapper.h to do this: ``` glslang::TDefaultGlslIoResolver* resolver = nullptr; for (auto e : GX_ShaderStage()) { auto& stage = myShaderInfo->stages[e]; if (!stage.isValid()) continue; auto* intermediate...

Change to CMake install rule for the include directory?

No problem, happy to change my usage.

Change to CMake install rule for the include directory?

Will do, it's on my short term todo.

Change to CMake install rule for the include directory?

Looks like I'm missing access to `setAutoPushConstantBlock()` that used to be part of the glslang::TIoMapper. Could that be made virtual in the base class? Also the `glslang::SpirvToolsEliminateDeadInputComponents()` workflow requires access...