Broadway icon indicating copy to clipboard operation
Broadway copied to clipboard

Compiler setting NO_BROWSER=1 is ignored

Open Bec-k opened this issue 3 years ago • 7 comments

I have found same version of emscripten and managed to re-compile, but it seems that NO_BROWSER=1 setting is ignored and compiled code have Browser object inside.

How did you manage to compile without it?

Bec-k avatar Aug 21 '21 10:08 Bec-k

the compiler parameters do not reflect 100% what is neccessary to build broadway. they are the resulot of trial and error where a functional broadway reflects success and faster running broadway beats a slower one.

the parameters also change over time as you pointed out. i believe it is a relict from a time where i compiled the webworker version seperately.

i recommend using the latest emscripten version and fine tunining it yourself if you are into that. you may get a few % performance out of it.

let us know you results pleas

soliton4 avatar Aug 21 '21 11:08 soliton4

When i'm trying to pipe h.264 baseline video stream from camera over RTSP and -c copy -f rawvideo via ffmpeg, it is complaining about memory on browser side, that's why i have tried to recompile it with higher memory limit, but it was not reacting to that setting... I just kept re-encoding on ffmpeg side without -c copy and it is working fine now. I kept it like that, no time to invest into new version of emscripten right now, maybe i'll research that area later. Anyway, thank you for your stuff, it is still working like a charm, over so much years :+1:

Bec-k avatar Aug 23 '21 13:08 Bec-k

you could try to use ALLOW_MEMORY_GROWTH=1

see if that changes your memory issues. i dont recommend using that parameter for the final version as i belive it has performance compromises. but its worth investigating

https://emscripten.org/docs/optimizing/Optimizing-Code.html

soliton4 avatar Aug 23 '21 13:08 soliton4

I tried to compile and remove Browser variables manually, video wasn't decoded properly and no error was thrown. Maybe there is some debugging mode both from WASM side and on js side? I could post the output here.

Bec-k avatar Aug 29 '21 09:08 Bec-k

@soliton4, when decoding the 4K H.264 video, I got the memory limit issue. image

Please see the #230 issue for more detail. I need your help. Thanks.

myjimmy avatar Sep 13 '21 05:09 myjimmy

@myjimmy sorry i am not working full time on broadway. just got back to it compile broadway with higher memory setting and you should be fine

soliton4 avatar Dec 17 '21 15:12 soliton4

@soliton4 Thanks very much.

myjimmy avatar Dec 18 '21 15:12 myjimmy