LiteDB icon indicating copy to clipboard operation
LiteDB copied to clipboard

Fix security issue for V4

Open viveleltsi opened this issue 1 year ago • 6 comments

Fix the severity issue for the old v4 liteDB version. The goal is to have a patch for application who cannot update to V5.

Because this is my first PR for this project I think my changes should be properly checked and validated.

fix #2418

PS: This branch should not be merged on master but probably stay on a fix branch.

viveleltsi avatar Feb 19 '24 10:02 viveleltsi

Hi @viveleltsi, thanks for your code. Your v4 source, did you get from v4 branch or from v4.1.4 tag?

mbdavid avatar Feb 19 '24 16:02 mbdavid

Hi @viveleltsi, thanks for your code. Your v4 source, did you get from v4 branch or from v4.1.4 tag?

Hello ! Thank you for your response. My branch was created on the v4.1.4 tag. (commit 918b6500b16bcb85a1d2e713c5486bd6491f9016). Would you like me to try rebasing it on the v4 branch ? (Sorry I didn't saw this branch :S )

viveleltsi avatar Feb 19 '24 19:02 viveleltsi

I rebase my branch onto the V4 branch (commit 46a83879e31a66e02a46d84ec695e537434dbdef) and I rebuild it and run the unit testing. It's all good.

viveleltsi avatar Feb 20 '24 08:02 viveleltsi

Nice! Thanks.... Could you create a pull request for v4 branch? Than I will create a new tag for this new release

mbdavid avatar Feb 21 '24 00:02 mbdavid

Yes of course. I updated this PR to target the v4 branch.

viveleltsi avatar Feb 21 '24 06:02 viveleltsi

@mbdavid I updated the PR to the v4 branch :)

viveleltsi avatar Mar 04 '24 08:03 viveleltsi