iTerm2-Color-Schemes Rosé Pine selection background

The selection-background for rose-pine, rose-pine-moon and rose-pine-dawn Ghostty themes are the same as background so that it is impossible to see what is currently being selected.

I propose changing it to the value of palette = 0.

Same goes for the corresponding kitty themes. I didn't check any other themes.

Jun 02 '24 12:06 jukremer

Can you submit a PR with the proposed changes, including updated screenshots? Thanks!

Jun 11 '24 20:06 mbadolato

If I understand correctly, I change the corresponding file in schemes/ and generate the rest using the python script?

Jun 12 '24 07:06 jukremer

@janurskremer If you use iTerm, yeah you can load the scheme, change the color(s), and then run the script and it will generate for the other formats. If you're using something other than iTerm, I'm not sure how you would do it. The itermcolors file could be modified directly, but IIRC the values are not in RGB format

Jun 12 '24 13:06 mbadolato

Related #442

Jul 26 '24 16:07 jukremer

Hi @mbadolato.

I've opened a PR (#485) that fixes this issue and #442. Let me know if I missed something.

Dec 29 '24 19:12 julianolf

@jukremer Look good to you?

Dec 30 '24 16:12 mbadolato

The colors still don't match the source.

Dec 30 '24 18:12 jukremer

@jukremer, are you still having issues with the selection?

Jan 02 '25 23:01 julianolf

Probably not, but these are not the colors of this theme.

Jan 03 '25 12:01 jukremer

Probably not, but these are not the colors of this theme.

About the colors, I should've paid more attention to the outputted colors and the palette. I'm sorry for that. However, I've opened another PR and added some images to help validate in the issue #442. If you could take a look, any feedback would be much appreciated.

Jan 04 '25 20:01 julianolf

LGTM #500

Jan 04 '25 20:01 jukremer