bodyweight-fitness-ios icon indicating copy to clipboard operation
bodyweight-fitness-ios copied to clipboard

Published 20 hours ago • verified publisher icon mazurio

Contributing guide?

Open lalo2302 opened this issue 7 years ago • 6 comments

Hi!

I want to contribute to the development, but I see no guide, rules or whatever. Maybe a roadmap? A trello/asana board?

I can help in this things but I don't really know who is in charge of publishing or merging to master.

lalo2302 avatar Jan 08 '18 03:01 lalo2302

I'd also like to contribute to development, but am unsure of what needs to be done. I think a Trello board would be optimal for tracking features/bugs/etc...

blesson3 avatar Jan 09 '18 05:01 blesson3

Plus one to this. I'd honestly like to help with this too.

niko-dunixi avatar Jan 10 '18 19:01 niko-dunixi

We could all do it right here on Github, via the issues manager. We can set the enhancement label for features to add, and then do the pull requests.

Right now I see 2 things that can be done:

  1. Comment the code
  2. Add workouts to the Health App

Would be great if @mazurio gives an opinion about it 😄

lalo2302 avatar Jan 12 '18 18:01 lalo2302

It would be great if he could show up to share his plan with us, but I've read that @mazurio is busy with life stuff until June/July. You can search r/bodyweightfitness for his latest posts.

I've started adding the workouts to the Health App on this branch https://github.com/bamse16/bodyweight-fitness-ios/tree/feature/healthkit, however I can't test it without a paid developer account. HealthKit requires a special entitlement, that does not work with the free developer account.

Re what's left to do, there are a couple of bugfixes, in GitHub, and a couple of good suggestions on reddit. Also, there's a bit of refactoring needed. I wouldn't add comments to the code though. It's pretty easy to get it, once you've spent a bit of time.

bamse16 avatar Jan 13 '18 08:01 bamse16

Thanks @bamse16! Already read his posts at reddit. So I'll start working on bugfixes to start getting comfortable with the app. I only have 1 question:

If I use the app from the appstore, but at the same time I build and run the app of development on my device, is the app from the appstore gonna be replaced, erasing all my info?

EDIT: I think I can't run the app at all without a paid developer account :( Thought it was only the HealthKit, but it is needed for In-App purchases. Too bad. Any way, I may buy one in a few months.

lalo2302 avatar Jan 15 '18 19:01 lalo2302

To get it installed as a different app, make sure that you change the bundle identifier.

Regarding installing it on your phone, for HealthKit, you need an active paid account to do that. Hopefully, @mazurio can add us to his account, so we can distribute TestFlight builds.

bamse16 avatar Jan 15 '18 20:01 bamse16