use-pusher icon indicating copy to clipboard operation
use-pusher copied to clipboard

chore(package): remove react peer dep

Open markbello opened this issue 4 years ago • 2 comments

guardrails like this peer dep are a virtue, but afaik there's no way to have an explicit peer dep@^16.9.0 cross the major release boundary to ^17.x

this is causing problems for installing in apps that use react@17+, which now require a SKIP_PREFLIGHT_CHECK flag to install with this package (due to peer dependency problems)

maybe the README would be a better place for explicitly stating React@^16.9.0 is required for proper functioning?

markbello avatar Apr 28 '21 17:04 markbello

Do we know that it isn't compatible with React 17? Seems like there were few breaking changes in that release. If it is compatible, we could update the peer dependency to either:

"react": ">=16.9"

or

"react": "^16.9.0 || ^17.0.0"

LochandQuay avatar Dec 16 '21 00:12 LochandQuay

This package works great in React 17 and 18 apps. Any chance of merging this and letting the app ensure version compatibility? The stale version 16 requirement forces the app to use npm --legacy-peer-deps, which I'd like to remove.

dgraham avatar Jun 09 '22 17:06 dgraham