pkasolver icon indicating copy to clipboard operation
pkasolver copied to clipboard

Using subprocess to run dimorphite_dl

Open eladnoor opened this issue 2 years ago • 2 comments

Hello,

I've noticed that Dimorphite-DL is called via subprocess, although it is a python script and can probably be called directly as an imported package, which should be more efficient.

I can try to change it myself if this makes sense.

eladnoor avatar Jan 15 '23 13:01 eladnoor

Hello,

thanks for the initiative, yes that would indeed be much better! Yeah, I would appreciate, if you'd be willing to try it!

mayrf avatar Jan 15 '23 21:01 mayrf

Okay, it was quite easy to do. You can see the changes in this fork: https://github.com/mayrf/pkasolver/compare/main...eladnoor:pkasolver:main

I think it is working the same as before, however when I try running test_query, I get mostly errors. I am not sure, but I think the problem exists already in your branch - looking at the CI a lot of tests are skipped (exactly the ones that fail on my machine): https://github.com/mayrf/pkasolver/actions/runs/3926198791/jobs/6711694088#step:6:44

eladnoor avatar Jan 16 '23 14:01 eladnoor