Harry Li

Results 33 comments of Harry Li

没有错误吧,这行代码的意思是:获取不存在的key“unknown”,如果异常为空,也就是获取成功了。那么就打印错误。因为这个"unknown"是不存在的。

> > If you think this fixes the issue I'd be happy to submit a PR to fix this :) Just let me know! > > @JamesDChilds can you propose...

@jnan806 Hi, I use a map with host:port as key and openSergoClient as value to control reuse, and use sync.map to avoid concurrent access problems. I think it should work.

我可以尝试解决一下这个问题。

@sczyh30 This seems to be caused by too fast a send rate. I think it can be fixed by adding a send interval or `sync.Mutex ` control_plane.go:96 ~~~go const sendInterval...

When I set `--kaniko-dir=foo`, during kaniko execution, it still used the `config.KanikoDir` to get the environment variables(`KANIKO_DIR`), hance the problem in this issue. ~~~go // pkg/executor/build.go:807 dstDir := filepath.Join(config.KanikoDir, strconv.Itoa(index))...

> Looks good. Thank you! @matskiv Please rerun the tests.

> Naming is hard. I've added my feedback, but will also seek additional maintainer feedback. > Naming is hard. I've added my feedback, but will also seek additional maintainer feedback....

> @mayooot if you can resolve conflicts then we can merge. OK, Please review the last commit.