aframe-html-shader icon indicating copy to clipboard operation
aframe-html-shader copied to clipboard
verified publisher icon mayognaise

Added fallback check to geometry width/height ratio calculation

Open wosevision opened this issue 8 years ago • 1 comments

This pull request would address #6 – geometry.parameters is undefined in A-Frame >= 0.3.2, so I added a check for geometry.metadata.parameters beforehand that resolves to whichever version of the property is available (to cover both versions).

wosevision avatar Mar 09 '17 18:03 wosevision

@wosevision thank you for this PR. I just fixed conflicts. @ngokevin do you mind to review this?

mayognaise avatar Jun 19 '17 05:06 mayognaise