Matthieu Darbois

Results 359 comments of Matthieu Darbois

> no changes to auditwheel are needed. no changes are needed for the `pkg_with_sharedlib` but changes are required for the packages consuming `sharedlib.so.1` from that package. They will link against...

Thanks for the report & the analysis. I'm a bit hesitant to apply this config by default for now as it's dealing with some security issue & this just revert...

I made a similar observation in https://github.com/pypa/auditwheel/issues/257#issuecomment-725331063. > The only solution I see is to move the scripts to platlib, where we know its relative path to the .libs folder,...

> I do not really see a reason to not relocate the scripts to platlib in that situation too, perhaps I am missing something. If I understand correctly: If we...

we're between bug & enhancement. I'd say it was a limitation that scripts could not be repaired & marked as enhancements.

> But auditwheel does try to do something currently. you're right, relabeling. All ELF files are treated the same which might prevent a work around.

> I do think that it's worth having both unit and integration tests, although I see them more as labels for a gradient of tests than distinct categories. Same here...

> To build and test PyInstaller/cx-freeze based executables for every supported python version. @termim, can you please explain the use-case (or better, provide a real reference for the use-case) of...

Would you be by any chance in the same situation as https://github.com/pypa/auditwheel/issues/257 ?