Matthieu Darbois

Results 359 comments of Matthieu Darbois

Thanks for the update. I saw that it only supports cp310+, it probably is a showstopper for now if we want to make that check mandatory ? I think a...

I'll check the `RFC 4648`and try to make a PR to update the test suite and library to handle invalid input properly.

So, not much else than what you're saying after reviewing `RFC 4648`. First step, report all violations. Second step, allow whitespace. See #33

For now, I added validation for `base64_decode` function only. The streaming implementation would require a final step (as can be seen in validation for `base64_decode`). This requires adding a new...

Well, if I quote what you said in an earlier comment: > The compliance baseline for this library should be the relevant RFC 4648. I never liked Postel's law much...

OK, I see what you meant now. What bothers me with that viewpoint is that, if I'm not mistaken or missing something else, it's only valid for "terminated" Base64-encoded string....

There's an example of translation in https://github.com/mayeut/pybase64/blob/1e2f3ec63549085f06b3118671818edb969c1e3d/pybase64/_pybase64.c#L71 The translation is done in-place for encoding. The translation is done out-of-place for decoding (warning, the translation is not safe here to mimic...

Well the code for AVX2 was buggy before. It's still buggy now... I will make a PR to get this fixed.

Regarding you second bullet point, without any pointer to your configuration, it will be hard to provide any support. I'm on macOS, I have libtool installed, I can try to...

Regarding the `uint16_t` to `char` conversion as a preprocessing step, why not just use `_mm_packus_epi16`. There's no need to check for invalid characters with that pre-processing stage, the check will...