Michael Mayer

Results 161 comments of Michael Mayer

@jameslamb could you also add a Python tag? There, we would need two things: translating feature names to int positions, and adding the set of skipped features as additional set.

Question to @jameslamb and others: In Python, the interaction constraints are transformed into a string here, just like any other list of list-like object: https://github.com/microsoft/LightGBM/blob/master/python-package/lightgbm/basic.py, ```py def _param_dict_to_str(data: Optional[Dict[str, Any]])...

> > Is it an option to add a snippet like this? > > I'd prefer that that be done outside of `_param_dict_to_str()`, similar to how `categorical_feature` is resolved: >...

Getting a failing unit test: ``` -- 1. Failure (test_lgb.Booster.R:209:5): Loading a Booster from a text file wor bst2$params[names(params)] not equal to `params`. Component "interaction_constraints": Length mismatch: comparison on first...

> Hey @mayer79 , across your recent PRs I've seen multiple "fix linting" types of commits. Totally fine to keep using Continuous Integration to get that feedback (we don't have...

@jameslamb Increadible review, thank you so much for your dedication! Some comments: 1. Now, the user sees 1-based `start_iteration`. The conversion to 0-based is done before calling the R wrappers...

@trivialfis : Beginners question: How do you generate the rd help files in a convenient way? For other packages, I usually run `devtools::document()` or `devtools::document("R-package")`.. But that starts building the...

Both hints (almost) did the trick, thanks a lot! Remaining problem: The first step of @jameslamb fails after some time with a ``` D:\xgboost>R CMD INSTALL --with-keep.source ./R-package * installing...

Thanks for the support, and sorry for the troubles. This gives the same: ``` D:\xgboost\R-package>R CMD INSTALL . * installing to library 'C:/Users/Michael/AppData/Local/R/win-library/4.3' * installing *source* package 'xgboost' ... **...

You got me... I was still on rtools40 😇