videodownloader icon indicating copy to clipboard operation
videodownloader copied to clipboard

Use youtube-dl package

Open RossComputerGuy opened this issue 5 years ago • 7 comments

Wouldn't it be easier to use the youtube-dl package instead of having to download the executable?

RossComputerGuy avatar Jan 05 '20 02:01 RossComputerGuy

The issue I found is that youtube-dl as a module worked like 1/15th the speed of the executable. I opened an issue about it and nobody got back to me so I just rolled with the executable

mayeaux avatar Jan 05 '20 03:01 mayeaux

https://github.com/przemyslawpluta/node-youtube-dl/issues/251

mayeaux avatar Jan 05 '20 03:01 mayeaux

I had the same problem using youtube-dl package, I made a pull request that probably fix that :)

fredericgermain avatar Jan 12 '20 13:01 fredericgermain

Can you link the PR @fredericgermain ? . Would be interested in seeing what your solution was.

mayeaux avatar Jan 12 '20 21:01 mayeaux

That's the one https://github.com/przemyslawpluta/node-youtube-dl/pull/285

fredericgermain avatar Jan 13 '20 18:01 fredericgermain

Very cool, nice work that could have saved me a decent chunk of time if that had been already merged ;P

mayeaux avatar Jan 13 '20 22:01 mayeaux

Strange thing, I still experience this slow behaviour when specifying the format, on 3.1.0 or 3.0.0

rzfzr avatar Feb 14 '21 22:02 rzfzr