nodetube icon indicating copy to clipboard operation
nodetube copied to clipboard

Dark/Light mode switcher concept

Open BassOfBass opened this issue 3 years ago • 6 comments

I've made a rough sketch of this switcher at https://github.com/BassOfBass/nodetube/commit/08c24122d1dd3a413a44420e6b107ef7bbe856dd. Don't pay attention to the header, I am in the middle of cleaning it up.

The good parts:

  • doesn't rely on classes with !important values.
  • makes use of CSS variables, which can be manipulated on the fly, unlike SASS variables.
  • potentially can be extended to work with any user-customized color pair.

The bad part:

  • requires a particular way of styling so it will take a while before I fix up styling on other pages.

BassOfBass avatar Oct 16 '20 09:10 BassOfBass

Awesome I will check out this functionality in a sec.

Also here : /layoutPartials/sidebar.pug:269

There is a toggle button for light/dark. If you uncomment that out you can use that as a toggle, not sure what you're using atm

mayeaux avatar Oct 17 '20 00:10 mayeaux

I've added a different button. I tend not to delete comments unless I am absolute sure the code isn't needed.

BassOfBass avatar Oct 17 '20 03:10 BassOfBass

I added you as a collaborator for nodetube, are you able to accept that invite and then push this branch to the nodetube repo? Easier for me to check it out / submit it as a PR that way.

mayeaux avatar Oct 17 '20 16:10 mayeaux

First off we have to decide on workflow, as I am not a fan of pushing to master directly. There is a develop tree which was last updated 10 months ago, so maybe it's a good idea to use it as a general "test" branch before unloading the results to master.

BassOfBass avatar Oct 17 '20 18:10 BassOfBass

No but seriously, do I just commit to the master and hope for the best?

BassOfBass avatar Oct 20 '20 09:10 BassOfBass

No but seriously, do I just commit to the master and hope for the best?

Just submit a PR to master and we can track the changes in the PR.

mayeaux avatar Oct 20 '20 18:10 mayeaux