maybe icon indicating copy to clipboard operation
maybe copied to clipboard

Make all account names human readable

Open varkum opened this issue 1 year ago • 2 comments

Screenshot 2024-02-05 at 8 40 15 PM Screenshot 2024-02-05 at 8 40 09 PM

Fixed the above two names in the form to the following:

Screenshot 2024-02-05 at 9 04 27 PM Screenshot 2024-02-05 at 9 04 37 PM

I converted the type_name method to a class method. To me, it makes more sense to pass the class in the type local for the _account_type partial instead of instantializing each type just to access the type_name. It also eliminates the need to call .class then on every instance of the type in the partial.

varkum avatar Feb 06 '24 02:02 varkum

Is there a way to use a safe constantize here? We have to either rely on the accountable_type model attribute or the query param, both of which are marked as unsafe by scan_ruby

varkum avatar Feb 06 '24 14:02 varkum

I think this coukd be closed after #256

ricsdeol avatar Feb 07 '24 01:02 ricsdeol

A lot of changes to the add account flow so going to close this.

Shpigford avatar Feb 08 '24 17:02 Shpigford