easyexif icon indicating copy to clipboard operation
easyexif copied to clipboard

Wrong implementation parseFrom method?

Open alex-aparin opened this issue 6 years ago • 0 comments

I looked at implementation of parseFrom method, here is piece of code:

for (offs = 0; offs < len - 1; offs++) if (buf[offs] == 0xFF && buf[offs + 1] == 0xE1) break;

As I understand, it searches exif marker. Is it correct? AS I understand, we should skip internal data of markers, and here we should find length of marker segment, if it is not exif then we should skip it (otherwise we can accidentially find that marker data from different marker segment). Am I right?

alex-aparin avatar Aug 17 '18 13:08 alex-aparin