Mayank
Mayank
I've been following this issue for a while because I'm interested in a _"menuitem that navigates"_, but it seems like the discussion is focused almost entirely on the _"primary navigation...
I don't think there is much we can do here. While the `Tabs.Panel` remains mounted, the virtualizer unmounts the rows when the table is no longer visible (which makes sense!)...
It's worth mentioning that Vite allows using `base: "./"` which I've found works quite well for static/prerendered sites. All assets are looked up relatively, avoiding any issues with deeply-nested absolute...
> I'm not quite sure what to do here - with `basename: '/chat/'`, React Router _has_ to generate the file inside of a `chat/` directory so it can be deployed...
> this is actually achievable, what you need to do is set `build.assetsDir` in `vite.config.ts` to your basename (but without the slashes) while keeping the `base` unset. I was already...
Thanks for looking into this! I responded to some of the comments in your PR, and I mostly agree with your criticism of the API shape. However I do want...
Awesome! I quite like this small snippet: ```js new CloseWatcher().onclose = this.hide ``` Just a thought: should this replace the `bindKeypress` handling? Having both seems redundant and could maybe cause...
It might be worth testing the order of events. If `close` gets called first, then it will remove the `bindKeypress` event handler (via `hide`), which could again be a breaking...
I don't think `:root` should match the shadow host. Currently, `:root` is the only selector that never matches anything inside shadow DOM. Today, I can use this knowledge to write...
@bramus > I would expect `:root:has([popover]:popover-open)` to work in both cases. That's the thing, I would *not* expect this to work. `:root` is effectively the same as `html`, which does...